Skip to content

get_all_documents_generator does not implement what it promises to #8

@apohllo

Description

@apohllo

The method description says:

Get documents from the document store. Under-the-hood, documents are fetched in batches from the
        document store and yielded as individual documents. This method can be used to iteratively process
        a large number of documents without having to load all documents in memory.

while the implementation is:

for doc in self.get_all_documents(
            index, filters, return_embedding, batch_size, headers
        ):
            yield doc

I think NotImplementedError should be raised for this method.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions