Skip to content
This repository was archived by the owner on Aug 16, 2023. It is now read-only.

Commit cb83653

Browse files
authored
Service port name template according to Istio naming convention (#451)
Signed-off-by: Gleb Vazhenin <gleb.vazhenin@team.bumble.com>
1 parent 029e012 commit cb83653

4 files changed

Lines changed: 5 additions & 3 deletions

File tree

charts/milvus/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ name: milvus
33
appVersion: "2.2.9"
44
kubeVersion: "^1.10.0-0"
55
description: Milvus is an open-source vector database built to power AI applications and vector similarity search.
6-
version: 4.0.23
6+
version: 4.0.24
77
keywords:
88
- milvus
99
- elastic

charts/milvus/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -161,6 +161,7 @@ The following table lists the configurable parameters of the Milvus Service and
161161
| `extraConfigFiles` | Extra config to override default milvus.yaml | `user.yaml:` |
162162
| `service.type` | Service type | `ClusterIP` |
163163
| `service.port` | Port where service is exposed | `19530` |
164+
| `service.portName` | Useful for [Istio protocol selection](https://istio.io/latest/docs/ops/configuration/traffic-management/protocol-selection/) | `milvus` |
164165
| `service.nodePort` | Service nodePort | `unset` |
165166
| `service.annotations` | Service annotations | `{}` |
166167
| `service.labels` | Service custom labels | `{}` |

charts/milvus/templates/service.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ spec:
3636
type: {{ .Values.service.type }}
3737
{{- end }}
3838
ports:
39-
- name: milvus
39+
- name: {{ .Values.service.portName }}
4040
port: {{ .Values.service.port }}
4141
protocol: TCP
4242
targetPort: milvus
@@ -56,4 +56,4 @@ spec:
5656
{{- else if and .Values.proxy.enabled .Values.cluster.enabled }}
5757
component: "proxy"
5858
{{- end }}
59-
{{- end }}
59+
{{- end }}

charts/milvus/values.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ extraConfigFiles:
5858
service:
5959
type: ClusterIP
6060
port: 19530
61+
portName: milvus
6162
nodePort: ""
6263
annotations: {}
6364
labels: {}

0 commit comments

Comments
 (0)