Skip to content

fix: return error when get recall from empty result#48027

Open
aoiasd wants to merge 1 commit intomilvus-io:masterfrom
aoiasd:fix/recall-empty-result
Open

fix: return error when get recall from empty result#48027
aoiasd wants to merge 1 commit intomilvus-io:masterfrom
aoiasd:fix/recall-empty-result

Conversation

@aoiasd
Copy link
Contributor

@aoiasd aoiasd commented Mar 5, 2026

relate: #43443

@sre-ci-robot
Copy link
Contributor

sre-ci-robot commented Mar 5, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aoiasd
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Mar 5, 2026
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Mar 5, 2026
@sre-ci-robot
Copy link
Contributor

sre-ci-robot commented Mar 5, 2026

[ci-v2-notice]
Notice: New ci-v2 system is enabled for this PR.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-build-all // for ci-v2/build-all (multi-arch builds)
  • /ci-rerun-ut-integration // for ci-v2/ut-integration, will rerun ci-v2/build
  • /ci-rerun-ut-go // for ci-v2/ut-go, will rerun ci-v2/build
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp, will rerun ci-v2/build
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm
  • /ci-rerun-e2e-default // for ci-v2/e2e-default
  • /ci-rerun-ciloop // for ci-v2/ciloop (build + unit tests in one pipeline)

If you have any questions or requests, please contact @zhikunyao.

@sre-ci-robot sre-ci-robot added the low-code-coverage add test-label from zhikun, diff coverage > 80% label Mar 5, 2026
@codecov
Copy link

codecov bot commented Mar 5, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.49%. Comparing base (3f16b85) to head (de9fc75).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #48027    +/-   ##
========================================
  Coverage   77.48%   77.49%            
========================================
  Files        2107     2107            
  Lines      348666   348820   +154     
========================================
+ Hits       270181   270326   +145     
+ Misses      70225    70222     -3     
- Partials     8260     8272    +12
Components Coverage Δ
Client 78.65% <ø> (ø)
Core 83.95% <ø> (ø)
Go 75.65% <87.04%> (+0.01%) ⬆️
Files with missing lines Coverage Δ
internal/proxy/util.go 79.07% <100.00%> (+0.04%) ⬆️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sre-ci-robot sre-ci-robot removed the low-code-coverage add test-label from zhikun, diff coverage > 80% label Mar 5, 2026
@mergify mergify bot added the ci-passed label Mar 5, 2026
@aoiasd aoiasd force-pushed the fix/recall-empty-result branch from 6bb1c56 to 1771698 Compare March 5, 2026 07:53
@aoiasd
Copy link
Contributor Author

aoiasd commented Mar 11, 2026

/ci-rerun-code-check

@aoiasd aoiasd force-pushed the fix/recall-empty-result branch 2 times, most recently from 703857d to 93d0dc4 Compare March 13, 2026 09:07
@mergify mergify bot added the ci-passed label Mar 13, 2026
@aoiasd
Copy link
Contributor Author

aoiasd commented Mar 17, 2026

/ci-rerun-e2e-arm

@aoiasd aoiasd changed the title fix: return eror when get recall from empty result fix: return error when get recall from empty result Mar 17, 2026
@mergify
Copy link
Contributor

mergify bot commented Mar 17, 2026

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

@aoiasd
Copy link
Contributor Author

aoiasd commented Mar 18, 2026

rerun go-sdk

@mergify
Copy link
Contributor

mergify bot commented Mar 18, 2026

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

@aoiasd
Copy link
Contributor Author

aoiasd commented Mar 18, 2026

rerun go-sdk

@mergify
Copy link
Contributor

mergify bot commented Mar 18, 2026

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

@aoiasd
Copy link
Contributor Author

aoiasd commented Mar 19, 2026

rerun go-sdk

1 similar comment
@aoiasd
Copy link
Contributor Author

aoiasd commented Mar 19, 2026

rerun go-sdk

@mergify
Copy link
Contributor

mergify bot commented Mar 19, 2026

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

@aoiasd
fix return eror when get recall from empty result
de9fc75 
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
@aoiasd aoiasd force-pushed the fix/recall-empty-result branch from 93d0dc4 to de9fc75 Compare March 19, 2026 04:00
@mergify
Copy link
Contributor

mergify bot commented Mar 19, 2026

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@godchen0212 godchen0212 Awaiting requested review from godchen0212

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees

No one assigned

Labels

dco-passed DCO check passed. kind/bug Issues or changes related a bug size/M Denotes a PR that changes 30-99 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aoiasd @sre-ci-robot