fix: HashTable dynamic rehash and group count limit for GROUP BY aggregation#48174
fix: HashTable dynamic rehash and group count limit for GROUP BY aggregation#48174MrPresent-Han wants to merge 1 commit intomilvus-io:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MrPresent-Han The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
[ci-v2-notice] To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
|
@MrPresent-Han go-sdk check failed, comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #48174 +/- ##
==========================================
- Coverage 77.29% 77.27% -0.03%
==========================================
Files 2080 2080
Lines 342401 342544 +143
==========================================
+ Hits 264654 264690 +36
- Misses 69492 69575 +83
- Partials 8255 8279 +24
🚀 New features to boost your workflow:
|
4bb6ab8 to
c1e903b
Compare
c1e903b to
d47f238
Compare
d47f238 to
8330542
Compare
|
has verified by cc reviewers team |
8330542 to
d75ad20
Compare
|
@MrPresent-Han go-sdk check failed, comment |
d75ad20 to
010ea9a
Compare
010ea9a to
3511def
Compare
…egation (milvus-io#47569) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: MrPresent-Han <chun.han@gmail.com>
3511def to
a09924e
Compare
|
@MrPresent-Han go-sdk check failed, comment |
Summary
queryNode.segcore.maxGroupByGroups(default 100K) to cap total groups and prevent OOM on both C++ (per-segment HashTable) and Go (cross-segment agg reducer) layersissue: #47569
Test plan
--gtest_filter="*HashTableRehash*:*MaxGroups*"queryNode.segcore.maxGroupByGroupsto small value, verify clear error message🤖 Generated with Claude Code