Skip to content

enhance: support dynamic update access log configuration#48273

Open
aoiasd wants to merge 1 commit intomilvus-io:masterfrom
aoiasd:access_log
Open

enhance: support dynamic update access log configuration#48273
aoiasd wants to merge 1 commit intomilvus-io:masterfrom
aoiasd:access_log

Conversation

@aoiasd
Copy link
Contributor

@aoiasd aoiasd commented Mar 16, 2026

Summary

  • Support dynamically updating access log configuration (formatters, methods, writer settings) without restarting, by watching all proxy.accessLog config keys instead of only the enable switch.
  • Add RESTful API paths (/search, /query, /v2/vectordb/entities/*) to the default search/query formatter methods, so RESTful requests also get detailed access log formatting.
  • Fix resource leak: close old RotateWriter before re-initializing when config changes.

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aoiasd
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Mar 16, 2026
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Mar 16, 2026
@sre-ci-robot
Copy link
Contributor

[ci-v2-notice]
Notice: New ci-v2 system is enabled for this PR.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-build-all // for ci-v2/build-all (multi-arch builds)
  • /ci-rerun-ut-integration // for ci-v2/ut-integration, will rerun ci-v2/build
  • /ci-rerun-ut-go // for ci-v2/ut-go, will rerun ci-v2/build
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp, will rerun ci-v2/build
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm
  • /ci-rerun-e2e-default // for ci-v2/e2e-default
  • /ci-rerun-ciloop // for ci-v2/ciloop (build + unit tests in one pipeline)

If you have any questions or requests, please contact @zhikunyao.

@mergify
Copy link
Contributor

mergify bot commented Mar 16, 2026

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

@aoiasd
Copy link
Contributor Author

aoiasd commented Mar 16, 2026

rerun go-sdk

@mergify
Copy link
Contributor

mergify bot commented Mar 16, 2026

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.19%. Comparing base (3f16b85) to head (096fc15).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #48273       +/-   ##
===========================================
+ Coverage   77.48%   83.19%    +5.70%     
===========================================
  Files        2107      639     -1468     
  Lines      348666   105723   -242943     
===========================================
- Hits       270181    87960   -182221     
+ Misses      70225    17711    -52514     
+ Partials     8260       52     -8208     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 83.95% <ø> (ø)
Go ∅ <ø> (∅)
see 1468 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sre-ci-robot sre-ci-robot added the low-code-coverage add test-label from zhikun, diff coverage > 80% label Mar 16, 2026
@aoiasd
Copy link
Contributor Author

aoiasd commented Mar 17, 2026

/ci-rerun-e2e-default

@aoiasd
Copy link
Contributor Author

aoiasd commented Mar 17, 2026

/ci-rerun-ut-go

@aoiasd
Copy link
Contributor Author

aoiasd commented Mar 17, 2026

/ci-rerun-ut-cpp

@aoiasd
Copy link
Contributor Author

aoiasd commented Mar 17, 2026

rerun go-sdk

@mergify
Copy link
Contributor

mergify bot commented Mar 17, 2026

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Mar 17, 2026

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

@aoiasd
Copy link
Contributor Author

aoiasd commented Mar 17, 2026

rerun go-sdk

@mergify
Copy link
Contributor

mergify bot commented Mar 17, 2026

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

@aoiasd
Copy link
Contributor Author

aoiasd commented Mar 18, 2026

/ci-rerun-e2e-arm

@aoiasd
Copy link
Contributor Author

aoiasd commented Mar 18, 2026

/ci-rerun-ut-go

@aoiasd
Copy link
Contributor Author

aoiasd commented Mar 18, 2026

rerun go-sdk

@mergify
Copy link
Contributor

mergify bot commented Mar 18, 2026

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
@mergify
Copy link
Contributor

mergify bot commented Mar 19, 2026

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement low-code-coverage add test-label from zhikun, diff coverage > 80% size/M Denotes a PR that changes 30-99 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants