Skip to content

fix: change IO related rust unwrap to ?#48333

Open
SpadeA-Tang wants to merge 2 commits intomilvus-io:masterfrom
SpadeA-Tang:fix-unwrap
Open

fix: change IO related rust unwrap to ?#48333
SpadeA-Tang wants to merge 2 commits intomilvus-io:masterfrom
SpadeA-Tang:fix-unwrap

Conversation

@SpadeA-Tang
Copy link
Contributor

issue: #48320

Signed-off-by: SpadeA <tangchenjie1210@gmail.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SpadeA-Tang
To complete the pull request process, please assign tedxu after the PR has been reviewed.
You can assign the PR to them by writing /assign @tedxu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Mar 18, 2026
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Mar 18, 2026
@sre-ci-robot
Copy link
Contributor

[ci-v2-notice]
Notice: New ci-v2 system is enabled for this PR.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-build-all // for ci-v2/build-all (multi-arch builds)
  • /ci-rerun-build-env // for ci-v2/build-env (build milvus-env builder images)
  • /ci-rerun-ut-integration // for ci-v2/ut-integration, will rerun ci-v2/build
  • /ci-rerun-ut-go // for ci-v2/ut-go, will rerun ci-v2/build
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp, will rerun ci-v2/build
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm
  • /ci-rerun-e2e-default // for ci-v2/e2e-default
  • /ci-rerun-ciloop // for ci-v2/ciloop (build + unit tests in one pipeline)

If you have any questions or requests, please contact @zhikunyao.

@chyezh
Copy link
Contributor

chyezh commented Mar 18, 2026

/lgtm

@sre-ci-robot sre-ci-robot added lgtm low-code-coverage add test-label from zhikun, diff coverage > 80% labels Mar 18, 2026
@codecov
Copy link

codecov bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.37%. Comparing base (8900b46) to head (d86705a).
⚠️ Report is 14 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #48333      +/-   ##
==========================================
- Coverage   77.53%   77.37%   -0.17%     
==========================================
  Files        2099     2099              
  Lines      348958   347554    -1404     
==========================================
- Hits       270576   268926    -1650     
- Misses      70137    70340     +203     
- Partials     8245     8288      +43     
Components Coverage Δ
Client 78.62% <ø> (ø)
Core 83.95% <ø> (-0.01%) ⬇️
Go 75.46% <63.70%> (-0.26%) ⬇️
see 35 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SpadeA-Tang
Copy link
Contributor Author

/ci-rerun-code-check

Signed-off-by: SpadeA <tangchenjie1210@gmail.com>
@sre-ci-robot sre-ci-robot removed the lgtm label Mar 19, 2026
@sre-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@mergify
Copy link
Contributor

mergify bot commented Mar 19, 2026

@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-passed DCO check passed. kind/bug Issues or changes related a bug low-code-coverage add test-label from zhikun, diff coverage > 80% size/S Denotes a PR that changes 10-29 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants