Skip to content

remove equals sign from filename in add_spl_to_patients.py #7

@Vincent-Ustach

Description

@Vincent-Ustach

I noticed that the script add_spl_to_patients.py generates filenames that include an equals sign (=).

spl_matrix_fname = project_config.MY_DATA_DIR / f'{args.save_prefix}_agg={args.agg_type}_spl_matrix.npy'

'mydata_agg=mean_spl_matrix.npy'

While this is technically allowed, I recommend avoiding this character in filenames. There are a few reasons for this, such as cross-platform compatibility, shell and command line confusion, potential for automation conflicts, and readability.

Recommendation: Consider replacing the equals sign with a more neutral character, such as an underscore (_) or a dash (-).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions