Skip to content

Commit 9525df8

Browse files
committed
Addressed PR comments.
1 parent 50f2fb9 commit 9525df8

File tree

7 files changed

+16
-36
lines changed

7 files changed

+16
-36
lines changed

data-sources/ghapi.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ rest:
1414
type: string
1515
repo:
1616
type: string
17-
repo:
17+
repo_config:
1818
endpoint: https://api.github.com/repos/{owner}/{repo}
1919
parse: json
2020
input_schema:

security-baseline/rule-types/github/osps-ac-03.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
version: v1
22
release_phase: alpha
33
type: rule-type
4-
name: osps-ac-04
4+
name: osps-ac-03
55
display_name: Prevent overwriting git history
66
short_failure_message: Force pushes are allowed
77
severity:

security-baseline/rule-types/github/osps-do-01.yaml

+6-16
Original file line numberDiff line numberDiff line change
@@ -35,20 +35,10 @@ def:
3535
3636
default allow := false
3737
38-
allow if {
39-
repo := minder.datasource.ghapi.repo({
40-
"owner": input.properties["github/repo_owner"],
41-
"repo": input.properties["github/repo_name"]
42-
})
38+
repo := minder.datasource.ghapi.repo_config({
39+
"owner": input.properties["github/repo_owner"],
40+
"repo": input.properties["github/repo_name"]
41+
})
4342
44-
repo.body.has_issues
45-
}
46-
47-
allow if {
48-
repo := minder.datasource.ghapi.repo({
49-
"owner": input.properties["github/repo_owner"],
50-
"repo": input.properties["github/repo_name"]
51-
})
52-
53-
repo.body.has_discussions
54-
}
43+
allow if repo.body.has_issues
44+
allow if repo.body.has_discussions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
Apache License
2-
Version 2.0, January 2004
3-
http://www.apache.org/licenses/
1+
# Contributing to Foo
42

5-
TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
6-
7-
...
3+
We welcome contributions, and the rest of this doc is slap-dash! Sorry!
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
Apache License
2-
Version 2.0, January 2004
3-
http://www.apache.org/licenses/
1+
** Contributing to Foo **
42

5-
TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
6-
7-
...
3+
We welcome contributions, and the rest of this doc is slap-dash! Sorry!
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
1-
Apache License
2-
Version 2.0, January 2004
3-
http://www.apache.org/licenses/
1+
###################
2+
# Contributor Guide
3+
###################
44

5-
TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
6-
7-
...
5+
This project has a lot to read. Get started!

0 commit comments

Comments
 (0)