Skip to content

Scorecard rule requires fields that are not marked as required #211

Open
@eleftherias

Description

For the ruletype scorecard_enabled, if you create a profile and turn on remediation, you must set both retention_days and sarif_file, otherwise you will get an error cannot get PR remediation params: cannot create PR entries: cannot execute content template (index 0): template: Content[0]:26:36: executing "Content[0]" at <.Profile.sarif_file>: map has no entry for key "sarif_file".

We should either mark those fields as requires, which breaks backwards compatibility, or find a way to use the defaults in Minder and any clients.

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions