Skip to content

Commit c010959

Browse files
authored
Merge pull request #153 from mindsdb/webpage-kb-url-fix
Don't use URL in Knowledge Base or Skill Name
2 parents 91462bd + a6dac20 commit c010959

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

mindsdb_sdk/agents.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -354,25 +354,21 @@ def add_webpages(
354354
"""
355355
if not urls:
356356
return
357-
domain = ''
358-
path = ''
359357
agent = self.get(name)
360358
for url in urls:
361359
# Validate URLs.
362-
parsed_url = urlparse(url)
363-
domain = parsed_url.netloc.replace('.', '_')
364-
path = parsed_url.path.replace('/', '_')
360+
_ = urlparse(url)
365361
if knowledge_base is not None:
366362
kb = self.knowledge_bases.get(knowledge_base)
367363
else:
368-
kb_name = f'{name}_{domain}{path}_{uuid4()}_kb'
364+
kb_name = f'{name}_web_{uuid4()}_kb'
369365
kb = self._create_default_knowledge_base(agent, kb_name)
370366

371367
# Insert crawled webpage.
372368
kb.insert_webpages(urls, crawl_depth=crawl_depth, filters=filters)
373369

374370
# Make sure skill name is unique.
375-
skill_name = f'{domain}{path}_retrieval_skill_{uuid4()}'
371+
skill_name = f'web_retrieval_skill_{uuid4()}'
376372
retrieval_params = {
377373
'source': kb.name,
378374
'description': description,

0 commit comments

Comments
 (0)