Reworking handlers to avoid returning errors

Author: mindstorm38

rust/src/standard/download.rs renamed to rust/src/download.rs

@@ -1,4 +1,4 @@
-//! Parallel download implementation for standard installer.
+//! Parallel download implementation.
 //! 
 //! Partially inspired by: https://patshaughnessy.net/2020/1/20/downloading-100000-files-using-async-rust
 
@@ -17,9 +17,12 @@ use tokio::task::JoinSet;
 use tokio::sync::mpsc;
 use tokio::fs::File;
 
-use crate::http;
 
-use super::{serde, Event, Handler, Installer, Result, Error};
+/// A list of pending download that can be all downloaded at once.
+#[derive(Debug)]
+pub struct DownloadList {
+    inner: Vec<Download>,
+}
 
 
 /// Bulk download blocking entrypoint.
@@ -84,7 +87,7 @@ pub async fn download_many(
     })?;
 
     // Initialize the HTTP(S) client.
-    let client = http::builder()
+    let client = crate::http::builder()
         .build()
         .unwrap(); // FIXME:
 
@@ -253,6 +256,10 @@ async fn download_core(
 
 }
 
+pub trait DownloadWatcher {
+    
+}
+
 /// A download entry that can be delayed until a call to [`Handler::flush_download`].
 /// This download object borrows the URL and file path.
 #[derive(Debug, Clone, PartialEq, Eq)]
@@ -291,17 +298,17 @@ impl DownloadSource {
 
 }
 
-impl<'a> From<&'a serde::Download> for DownloadSource {
+// impl<'a> From<&'a serde::Download> for DownloadSource {
 
-    fn from(serde: &'a serde::Download) -> Self {
-        Self {
-            url: serde.url.clone().into(),
-            size: serde.size,
-            sha1: serde.sha1.as_deref().copied(),
-        }
-    }
+//     fn from(serde: &'a serde::Download) -> Self {
+//         Self {
+//             url: serde.url.clone().into(),
+//             size: serde.size,
+//             sha1: serde.sha1.as_deref().copied(),
+//         }
+//     }
 
-}
+// }
 
 #[derive(thiserror::Error, Debug)]
 pub enum DownloadError {

rust/src/lib.rs

@@ -4,6 +4,7 @@
 pub mod gav;
 pub mod path;
 pub mod http;
+pub mod download;
 
 pub mod standard;
 pub mod mojang;

rust/src/mojang/manifest.rs

@@ -1,9 +1,9 @@
 //! Optionally cached Mojang manifest.
 
+use std::io::{self, BufReader};
 use std::path::PathBuf;
 use std::fs::File;
 
-use crate::standard::{Result, Error};
 use super::serde;
 
 
@@ -32,21 +32,29 @@ impl MojangManifest {
         }
     }
 
-    pub fn get(&mut self) -> &serde::MojangManifest {
+    pub fn get(&mut self) -> io::Result<&serde::MojangManifest> {
 
         if let Some(data) = &self.data {
-            return data;
+            return Ok(data);
         }
 
         if let Some(cache_file) = self.cache_file.as_deref() {
+
+            let cache_reader = match File::open(cache_file) {
+                Ok(reader) => BufReader::new(reader),
+                Err(e) if e.kind() == io::ErrorKind::NotFound 
+            }
 
-            // let file = File::open(cache_file)
-            //     .map_err(|e| )
+            self.datamatch serde_json::from_reader(BufReader::new(File::open(cache_file)?)) {
+                Ok(obj) => obj
+            }
 
         }
 
         todo!()
 
     }
 
+    fn 
+
 }

rust/src/standard/mod.rs

@@ -1,7 +1,6 @@
 //! Standard installation procedure.
 
 pub mod serde;
-mod download;
 
 use std::io::{self, BufReader, Seek, SeekFrom};
 use std::collections::{HashMap, HashSet};
@@ -14,8 +13,6 @@ use sha1::{Digest, Sha1};
 use crate::path::PathExt;
 use crate::gav::Gav;
 
-pub use self::download::{Download, DownloadSource, DownloadError};
-
 
 /// Base URL for downloading game's assets.
 const RESOURCES_URL: &str = "https://resources.download.minecraft.net/";