[wieldview] Orientation of Shovels are wrong/strange

[Distributed-DeadLock]

Hi,
at least the shovels from Minetest_game/default & from Ethereal are orientated wrong,
or at least the orientation is inconsistent with the other tools.

These mods provide a transformed wield-image for shovels,
e.g. : wield_image = "default_tool_woodshovel.png^[transformR90",, (in minetest_game/mods/default/tools.lua Line 123).
As a result the shovels will be held more like a gun, alligned parallel to the arm, and not held in the hand.

I'd really like to have at least an option to change this behaviour.

Cheers

[SmallJoker]

Affected mod: 3d_armor/wieldview

1st person view

3rd person view

There is no suitable digging animation that would fit the shovel. It looks incorrect in the current state and also with a 270° rotated texture. I don't think this can or should be changed without introducing a better animation.

---

If you'd like to compare it by yourself; here's the requested "fix":

diff --git a/wieldview/transform.lua b/wieldview/transform.lua
index 4d5133e..f609982 100644
--- a/wieldview/transform.lua
+++ b/wieldview/transform.lua
@@ -22,3 +22,9 @@ wieldview.transform = {
 	["vessels:steel_bottle"]="R270",
 }
 
+for name, def in pairs(core.registered_tools) do
+	if (def.groups.shovel or 0) > 0 then
+		wieldview.transform[name] = "R270"
+		print("add" ,name)
+	end
+end

[Distributed-DeadLock]

I don't think this can or should be changed without introducing a better animation.

I disagree with that. I think being consistent with the positioning of the other tools is better than the current solution.
But that's just my opinion, and i think we can happily agree to to disagree here.

Thank you for the fix you posted.
If i'm not mistaken, you made wieldview global.
So, if you don't mind, i'd like to take your code and make a mini-mod out of that and publish it.

Anyway thank you very much for this great mod.

Cheers

[SmallJoker]

If i'm not mistaken, you made wieldview global.

I don't know what you mean but wieldview is in the global namespace, i.e. in _G, thus adding these few lines to a separate mod to "fix up" wieldview is rather trivial.
I'd like to keep this issue open for a while in case someone would like to leave their opinion on this topic.

[Distributed-DeadLock]

thus adding these few lines to a separate mod to "fix up" wieldview is rather trivial.

Yes, and i already made it. I'm using it privately right now.

But it consists completly of your "few lines", your code (thanks again for it),
So i wanted to know, if it's okay with you, if i publish it.

But if you*re undecided right now, i'll ask again when you close the issue and it's still makes sense then.

Cheers

[SmallJoker]

So i wanted to know, if it's okay with you, if i publish it.

IMO that code is trivial; no need to ask. If you do need a license regardless: CC0.

[Distributed-DeadLock]

Thank you very much. I'll do so, if neccessary.
Cheers