minetest.place_node broken

[wsor4035]

using minetest.place_node in a protected area even when owned by the player does not work at all

[SmallJoker]

@wsor4035 Does this fix your issue?

diff --git a/api.lua b/api.lua
index e6fe90e..816d687 100644
--- a/api.lua
+++ b/api.lua
@@ -84,6 +84,9 @@ end
 
 -- Checks if the area is unprotected or owned by you
 function areas:canInteract(pos, name)
+       if name == "" then
+               return true -- Mods, namely minetest.item_place_node
+       end
        if minetest.check_player_privs(name, self.adminPrivs) then
                return true
        end

Also keep in mind that minetest.place_node respects buildable_to, whereas minetest.set_node ignores it.

[SmallJoker]

@wsor4035 Does this issue still occur?

[wsor4035]

No idea, it was something related to farlands reloaded. I'll look later today and see if I can figure out what it was from 4 years ago....

[wsor4035]

nice, i helpfully linked it way back when TerraQuest-Studios/farlands_reloaded@a17842b - but i couldnt read up yesterday

[SmallJoker]

Quick glance at other mods on how they handle core.place_node(pos, node, nil)

• simple_protection: allowed everywhere.
  • https://github.com/SmallJoker/simple_protection/blob/d357ba10d8f5f7b4327bfc61efbafe772df21589/misc_functions.lua#L20-L23
• protector: only allowed outside of protected areas.
  • https://codeberg.org/tenplus1/protector/src/commit/56b33bb50f06aa451cef303b6ab715842894a96e/init.lua#L385-L401
• landrush (legacy): allowed everywhere.
  • https://github.com/Bremaweb/landrush/blob/master/protection.lua#L3-L7
• areas: disallowed everywhere.

What would you like to have? Preferably, this is solved by the mod, by providing a (fake) player object.

[wsor4035]

if areas disallows, probably a bad idea for backwards compat to start allowing regardless of other factors. since placer has been added, probably should check that if passed in - that is the best solution since otherwise its a toss up if the caller owns the area or not