Skip to content

Commit 02f98cf

Browse files
committed
Fix issues from sonar
1 parent 277cedb commit 02f98cf

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

src/JsBind.Net/Configurations/IJsBindOptionsConfigurator.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,14 @@ public interface IJsBindOptionsConfigurator
1212
/// </summary>
1313
/// <param name="value">Whether to use the in process JS runtime.</param>
1414
/// <returns>The configurator.</returns>
15-
public IJsBindOptionsConfigurator UseInProcessJsRuntime(bool value = true);
15+
IJsBindOptionsConfigurator UseInProcessJsRuntime(bool value = true);
1616

1717
/// <summary>
1818
/// Configure the bindings.
1919
/// </summary>
2020
/// <param name="configureAction">The action to configure the bindings.</param>
2121
/// <returns>The configurator.</returns>
22-
public IJsBindOptionsConfigurator ConfigureBinding(Action<IBindingConfigurator> configureAction);
22+
IJsBindOptionsConfigurator ConfigureBinding(Action<IBindingConfigurator> configureAction);
2323

2424
/// <summary>
2525
/// Gets the options configured.

src/JsBind.Net/Internal/DelegateReferences/JsFunctionProxyInvokeFunction.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ namespace JsBind.Net.Internal.DelegateReferences;
1010
internal partial class JsFunctionProxy : FunctionBindingBase
1111
{
1212
#pragma warning disable S3011 // Reflection should not be used to increase accessibility of classes, methods, or fields
13-
static Dictionary<string, MethodInfo> InvokeMethods = typeof(JsFunctionProxy)
13+
private static readonly Dictionary<string, MethodInfo> InvokeMethods = typeof(JsFunctionProxy)
1414
.GetMethods(BindingFlags.NonPublic | BindingFlags.Instance | BindingFlags.DeclaredOnly)
1515
.ToDictionary(methodInfo => methodInfo.Name + (methodInfo.IsGenericMethod ? methodInfo.GetGenericArguments().Length : string.Empty), methodInfo => methodInfo);
1616
#pragma warning restore S3011 // Reflection should not be used to increase accessibility of classes, methods, or fields

src/JsBind.Net/Internal/References/DelegateReference.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ internal class DelegateReference(string? delegateId, IEnumerable<ObjectBindingCo
2222
public IEnumerable<ObjectBindingConfiguration?>? ArgumentBindings { get; } = argumentBindings;
2323

2424
[JsonPropertyName("storeArgumentsAsReferences")]
25-
public IEnumerable<bool>? StoreArgumentsAsReferences => ArgumentBindings is not null ? ArgumentBindings.Select(binding => binding is not null) : null;
25+
public IEnumerable<bool>? StoreArgumentsAsReferences => ArgumentBindings?.Select(binding => binding is not null);
2626

2727
/// <summary>
2828
/// Do not use this property from dotnet. The reference IDs will be generated again from JavaScript when necessary. Refer to Modules\DotNetDelegateProxy.js

0 commit comments

Comments
 (0)