Skip to content

Commit 8969abd

Browse files
authored
Removes some erroneous config options for webhook (#1444)
Closes #1434 These config options were likely a copy/paste error from other target types. Refer to https://github.com/minio/minio/blob/master/internal/event/target/webhook.go#L64-L73 for the correct list. This update matches that code.
1 parent 3298919 commit 8969abd

File tree

2 files changed

+2
-68
lines changed

2 files changed

+2
-68
lines changed

source/administration/monitoring/publish-events-to-webhook.rst

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ variables *or* by setting runtime configuration settings.
6767
set MINIO_NOTIFY_WEBHOOK_QUEUE_LIMIT_<IDENTIFIER>="<string>"
6868
set MINIO_NOTIFY_WEBHOOK_CLIENT_CERT_<IDENTIFIER>="<string>"
6969
set MINIO_NOTIFY_WEBHOOK_CLIENT_KEY_<IDENTIFIER>="<string>"
70-
set MINIO_NOTIFY_WEBHOOK_COMMENT_<IDENTIFIER>="<string>"
7170
7271
.. cond:: not windows
7372

@@ -81,7 +80,6 @@ variables *or* by setting runtime configuration settings.
8180
export MINIO_NOTIFY_WEBHOOK_QUEUE_LIMIT_<IDENTIFIER>="<string>"
8281
export MINIO_NOTIFY_WEBHOOK_CLIENT_CERT_<IDENTIFIER>="<string>"
8382
export MINIO_NOTIFY_WEBHOOK_CLIENT_KEY_<IDENTIFIER>="<string>"
84-
export MINIO_NOTIFY_WEBHOOK_COMMENT_<IDENTIFIER>="<string>"
8583
8684
- Replace ``<IDENTIFIER>`` with a unique descriptive string for the
8785
Webhook service endpoint. Use the same ``<IDENTIFIER>`` value for all
@@ -124,8 +122,7 @@ variables *or* by setting runtime configuration settings.
124122
queue_dir="<string>" \
125123
queue_limit="<string>" \
126124
client_cert="<string>" \
127-
client_key="<string>" \
128-
comment="<string>"
125+
client_key="<string>"
129126
130127
- Replace ``IDENTIFIER`` with a unique descriptive string for the
131128
Webhook service endpoint. The following examples in this procedure
@@ -279,8 +276,7 @@ for the Webhook service endpoint:
279276
queue_dir="<string>" \
280277
queue_limit="<string>" \
281278
client_cert="<string>" \
282-
client_key="<string>" \
283-
comment="<string>"
279+
client_key="<string>"
284280
285281
The :mc-conf:`notify_webhook endpoint <notify_webhook.endpoint>` configuration
286282
setting is the *minimum* required for an Webhook service endpoint. All other

source/reference/minio-server/settings/notifications/webhook-service.rst

Lines changed: 0 additions & 62 deletions
Original file line numberDiff line numberDiff line change
@@ -271,65 +271,3 @@ Client Key
271271
:delimiter: " "
272272
273273
Specify the path to the client private key to use for performing mTLS authentication to the webhook service.
274-
275-
MaxRetry
276-
~~~~~~~~
277-
278-
*Optional*
279-
280-
.. tab-set::
281-
282-
.. tab-item:: Environment Variable
283-
:sync: envvar
284-
285-
.. envvar:: MINIO_NOTIFY_WEBHOOK_MAX_RETRY
286-
287-
.. tab-item:: Configuration Setting
288-
:sync: config
289-
290-
.. mc-conf:: notify_webhook max_retry
291-
:delimiter: " "
292-
293-
Maximum number of attempts to retry an event send.
294-
By default, the max number of retries is set to ``0``.
295-
296-
RetryInterval
297-
~~~~~~~~~~~~~
298-
299-
*Optional*
300-
301-
.. tab-set::
302-
303-
.. tab-item:: Environment Variable
304-
:sync: envvar
305-
306-
.. envvar:: MINIO_NOTIFY_WEBHOOK_RETRY_INTERVAL
307-
308-
.. tab-item:: Configuration Setting
309-
:sync: config
310-
311-
.. mc-conf:: notify_webhook retry_interval
312-
:delimiter: " "
313-
314-
Length of time to wait between retry attempts.
315-
The default value is ``3s``.
316-
317-
Comment
318-
~~~~~~~
319-
320-
*Optional*
321-
322-
.. tab-set::
323-
324-
.. tab-item:: Environment Variable
325-
:sync: envvar
326-
327-
.. envvar:: MINIO_NOTIFY_WEBHOOK_COMMENT
328-
329-
.. tab-item:: Configuration Setting
330-
:sync: config
331-
332-
.. mc-conf:: notify_webhook comment
333-
:delimiter: " "
334-
335-
Specify a comment to associate with the Webhook configuration.

0 commit comments

Comments
 (0)