feat: make JSON lib configurable

Currently, a mix of goccy/json and encoding/json is used. Both
use the same interface; goccy/json is faster, however, it also
does questionable things with go:linkname.
Create a common package that can be switched (via build tags)
from one implementation to another, and use that in all packages.

Author: secDre4mer

Diff for: api-bucket-notification.go

@@ -26,7 +26,7 @@ import (
 	"net/url"
 	"time"
 
-	"github.com/goccy/go-json"
+	"github.com/minio/minio-go/v7/pkg/json"
 	"github.com/minio/minio-go/v7/pkg/notification"
 	"github.com/minio/minio-go/v7/pkg/s3utils"
 )

Diff for: api-bucket-replication.go

@@ -20,14 +20,14 @@ package minio
 import (
 	"bytes"
 	"context"
-	"encoding/json"
 	"encoding/xml"
 	"io"
 	"net/http"
 	"net/url"
 	"time"
 
 	"github.com/google/uuid"
+	"github.com/minio/minio-go/v7/pkg/json"
 	"github.com/minio/minio-go/v7/pkg/replication"
 	"github.com/minio/minio-go/v7/pkg/s3utils"
 )

Diff for: api-prompt-object.go

@@ -23,7 +23,7 @@ import (
 	"io"
 	"net/http"
 
-	"github.com/goccy/go-json"
+	"github.com/minio/minio-go/v7/pkg/json"
 	"github.com/minio/minio-go/v7/pkg/s3utils"
 )
 

Diff for: api-put-object-fan-out.go

@@ -19,7 +19,6 @@ package minio
 
 import (
 	"context"
-	"encoding/json"
 	"errors"
 	"io"
 	"mime/multipart"
@@ -29,6 +28,7 @@ import (
 	"time"
 
 	"github.com/minio/minio-go/v7/pkg/encrypt"
+	"github.com/minio/minio-go/v7/pkg/json"
 )
 
 // PutObjectFanOutEntry is per object entry fan-out metadata

Diff for: pkg/credentials/file_aws_credentials.go

@@ -18,7 +18,6 @@
 package credentials
 
 import (
-	"encoding/json"
 	"errors"
 	"os"
 	"os/exec"
@@ -27,6 +26,8 @@ import (
 	"time"
 
 	"github.com/go-ini/ini"
+
+	"github.com/minio/minio-go/v7/pkg/json"
 )
 
 // A externalProcessCredentials stores the output of a credential_process

Diff for: pkg/credentials/file_minio_client.go

@@ -22,7 +22,7 @@ import (
 	"path/filepath"
 	"runtime"
 
-	"github.com/goccy/go-json"
+	"github.com/minio/minio-go/v7/pkg/json"
 )
 
 // A FileMinioClient retrieves credentials from the current user's home

Diff for: pkg/credentials/iam_aws.go

@@ -31,7 +31,7 @@ import (
 	"strings"
 	"time"
 
-	"github.com/goccy/go-json"
+	"github.com/minio/minio-go/v7/pkg/json"
 )
 
 // DefaultExpiryWindow - Default expiry window.

Diff for: pkg/encrypt/server-side.go

@@ -23,7 +23,7 @@ import (
 	"errors"
 	"net/http"
 
-	"github.com/goccy/go-json"
+	"github.com/minio/minio-go/v7/pkg/json"
 	"golang.org/x/crypto/argon2"
 )
 

Diff for: pkg/json/json_goccy.go

@@ -0,0 +1,17 @@
+//go:build !stdlibjson
+
+package json
+
+import "github.com/goccy/go-json"
+
+var (
+	Unmarshal  = json.Unmarshal
+	Marshal    = json.Marshal
+	NewEncoder = json.NewEncoder
+	NewDecoder = json.NewDecoder
+)
+
+type (
+	Encoder = json.Encoder
+	Decoder = json.Decoder
+)

Diff for: pkg/json/json_stdlib.go

@@ -0,0 +1,17 @@
+//go:build stdlibjson
+
+package json
+
+import "encoding/json"
+
+var (
+	Unmarshal  = json.Unmarshal
+	Marshal    = json.Marshal
+	NewEncoder = json.NewEncoder
+	NewDecoder = json.NewDecoder
+)
+
+type (
+	Encoder = json.Encoder
+	Decoder = json.Decoder
+)

Diff for: pkg/lifecycle/lifecycle.go

@@ -19,10 +19,11 @@
 package lifecycle
 
 import (
-	"encoding/json"
 	"encoding/xml"
 	"errors"
 	"time"
+
+	"github.com/minio/minio-go/v7/pkg/json"
 )
 
 var errMissingStorageClass = errors.New("storage-class cannot be empty")

Diff for: pkg/lifecycle/lifecycle_test.go

@@ -19,10 +19,11 @@ package lifecycle
 
 import (
 	"bytes"
-	"encoding/json"
 	"encoding/xml"
 	"testing"
 	"time"
+
+	"github.com/minio/minio-go/v7/pkg/json"
 )
 
 func TestLifecycleUnmarshalJSON(t *testing.T) {

Diff for: pkg/policy/bucket-policy-condition.go

@@ -17,7 +17,11 @@
 
 package policy
 
-import "github.com/minio/minio-go/v7/pkg/set"
+import (
+	"encoding/json"
+
+	"github.com/minio/minio-go/v7/pkg/set"
+)
 
 // ConditionKeyMap - map of policy condition key and value.
 type ConditionKeyMap map[string]set.StringSet
@@ -92,6 +96,11 @@ func (cond ConditionMap) Remove(condKey string) {
 	delete(cond, condKey)
 }
 
+func (cond ConditionMap) MarshalJSON() ([]byte, error) {
+	// Must be encoded with stdlib json due to https://github.com/goccy/go-json/issues/543
+	return json.Marshal(map[string]ConditionKeyMap(cond))
+}
+
 // mergeConditionMap - returns new ConditionMap which contains merged key/value of two ConditionMap.
 func mergeConditionMap(condMap1, condMap2 ConditionMap) ConditionMap {
 	out := make(ConditionMap)

Diff for: pkg/policy/bucket-policy-condition_test.go

@@ -42,6 +42,7 @@ func TestConditionKeyMapAdd(t *testing.T) {
 
 	for _, testCase := range testCases {
 		condKeyMap.Add(testCase.key, testCase.value)
+		// Must be encoded with stdlib json due to https://github.com/goccy/go-json/issues/543
 		if data, err := json.Marshal(condKeyMap); err != nil {
 			t.Fatalf("Unable to marshal ConditionKeyMap to JSON, %s", err)
 		} else {

Diff for: pkg/policy/bucket-policy.go

@@ -18,11 +18,12 @@
 package policy
 
 import (
-	"encoding/json"
+	stdjson "encoding/json"
 	"errors"
 	"reflect"
 	"strings"
 
+	"github.com/minio/minio-go/v7/pkg/json"
 	"github.com/minio/minio-go/v7/pkg/set"
 )
 
@@ -121,6 +122,12 @@ type Statement struct {
 	Sid        string
 }
 
+func (s Statement) MarshalJSON() ([]byte, error) {
+	// use stdlib json marshaling, see https://github.com/goccy/go-json/pull/545
+	type AliasStatement Statement
+	return stdjson.Marshal(AliasStatement(s))
+}
+
 // BucketAccessPolicy - minio policy collection
 type BucketAccessPolicy struct {
 	Version    string      // date in YYYY-MM-DD format

Diff for: pkg/policy/bucket-policy_test.go

@@ -18,11 +18,11 @@
 package policy
 
 import (
-	"encoding/json"
 	"fmt"
 	"reflect"
 	"testing"
 
+	"github.com/minio/minio-go/v7/pkg/json"
 	"github.com/minio/minio-go/v7/pkg/set"
 )
 

Diff for: pkg/set/stringset.go

@@ -21,7 +21,7 @@ import (
 	"fmt"
 	"sort"
 
-	"github.com/goccy/go-json"
+	"github.com/minio/minio-go/v7/pkg/json"
 )
 
 // StringSet - uses map as set of strings.