Skip to content

Commit 344bea9

Browse files
authored
CDPTKAN-763: Software updates: rubocop-govuk (#2935)
* Update rubocop-govuk * Update date_validation.rb
1 parent 571d1c5 commit 344bea9

3 files changed

Lines changed: 18 additions & 17 deletions

File tree

Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ group :development do
6464
gem 'binding_of_caller'
6565
gem 'listen', '~> 3.8'
6666
gem 'rubocop'
67-
gem 'rubocop-govuk'
67+
gem 'rubocop-govuk', '~> 5.1.1'
6868
gem 'ruby-lsp'
6969
gem 'spring'
7070
gem 'spring-watcher-listen', '~> 2.1.0'

Gemfile.lock

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -574,7 +574,7 @@ GEM
574574
ostruct (0.6.1)
575575
pagy (6.5.0)
576576
parallel (1.26.3)
577-
parser (3.3.7.1)
577+
parser (3.3.11.1)
578578
ast (~> 2.4.1)
579579
racc
580580
pg (1.5.9)
@@ -675,39 +675,40 @@ GEM
675675
rspec-support (3.13.2)
676676
rspec_junit_formatter (0.6.0)
677677
rspec-core (>= 2, < 4, != 2.12.0)
678-
rubocop (1.74.0)
678+
rubocop (1.79.2)
679679
json (~> 2.3)
680680
language_server-protocol (~> 3.17.0.2)
681681
lint_roller (~> 1.1.0)
682682
parallel (~> 1.10)
683683
parser (>= 3.3.0.2)
684684
rainbow (>= 2.2.2, < 4.0)
685685
regexp_parser (>= 2.9.3, < 3.0)
686-
rubocop-ast (>= 1.38.0, < 2.0)
686+
rubocop-ast (>= 1.46.0, < 2.0)
687687
ruby-progressbar (~> 1.7)
688688
unicode-display_width (>= 2.4.0, < 4.0)
689-
rubocop-ast (1.39.0)
690-
parser (>= 3.3.1.0)
689+
rubocop-ast (1.46.0)
690+
parser (>= 3.3.7.2)
691+
prism (~> 1.4)
691692
rubocop-capybara (2.22.1)
692693
lint_roller (~> 1.1)
693694
rubocop (~> 1.72, >= 1.72.1)
694-
rubocop-govuk (5.1.0)
695-
rubocop (= 1.74.0)
696-
rubocop-ast (= 1.39.0)
695+
rubocop-govuk (5.1.20)
696+
rubocop (= 1.79.2)
697+
rubocop-ast (= 1.46.0)
697698
rubocop-capybara (= 2.22.1)
698-
rubocop-rails (= 2.30.3)
699+
rubocop-rails (= 2.33.3)
699700
rubocop-rake (= 0.7.1)
700-
rubocop-rspec (= 3.5.0)
701-
rubocop-rails (2.30.3)
701+
rubocop-rspec (= 3.6.0)
702+
rubocop-rails (2.33.3)
702703
activesupport (>= 4.2.0)
703704
lint_roller (~> 1.1)
704705
rack (>= 1.1)
705-
rubocop (>= 1.72.1, < 2.0)
706-
rubocop-ast (>= 1.38.0, < 2.0)
706+
rubocop (>= 1.75.0, < 2.0)
707+
rubocop-ast (>= 1.44.0, < 2.0)
707708
rubocop-rake (0.7.1)
708709
lint_roller (~> 1.1)
709710
rubocop (>= 1.72.1)
710-
rubocop-rspec (3.5.0)
711+
rubocop-rspec (3.6.0)
711712
lint_roller (~> 1.1)
712713
rubocop (~> 1.72, >= 1.72.1)
713714
ruby-lsp (0.26.9)
@@ -872,7 +873,7 @@ DEPENDENCIES
872873
rspec-rails
873874
rspec_junit_formatter
874875
rubocop
875-
rubocop-govuk
876+
rubocop-govuk (~> 5.1.1)
876877
ruby-lsp
877878
sass-rails (>= 6)
878879
selenium-webdriver (= 4.15.0)

app/models/component_validations/date_validation.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ class DateValidation < BaseComponentValidation
1515
validates_with DateValidator, if: :run_validation?
1616

1717
def run_validation?
18-
enabled? && (day.present? && month.present? && year.present?)
18+
enabled? && (day.present? && month.present? && year.present?) # rubocop:disable Style/RedundantParentheses
1919
end
2020

2121
def answered_day

0 commit comments

Comments
 (0)