[MAN-2071] Address review comments

anandelangovan1 · anandelangovan1 · commit 3d48debc2725 · 2026-06-04T20:19:05.000+01:00
diff --git a/server/controllers/activityLog.test.ts b/server/controllers/activityLog.test.ts
@@ -414,7 +414,7 @@ describe('/controllers/activityLogController', () => {
 
       expect(request.session.activityLogFilters).toEqual({
         keywords: '',
-        compliance: [],
+        compliance: {},
         crn,
       })
 
diff --git a/server/middleware/appointment-outcomes/getComplianceData.ts b/server/middleware/appointment-outcomes/getComplianceData.ts
@@ -37,7 +37,6 @@ export const getComplianceData = (hmppsAuthClient: HmppsAuthClient): Route<Promi
         res.locals.appointmentOutcome.compliance = {
           ...res.locals.appointmentOutcome.compliance,
           nonCompliance,
-          acceptableAbsenceCount: currentSentenceCompliance?.activity?.acceptableAbsenceCount,
         }
       } else {
         res.locals.appointmentOutcome.compliance = buildCompliance(
diff --git a/server/middleware/getPersonActivity.test.ts b/server/middleware/getPersonActivity.test.ts
@@ -175,7 +175,7 @@ describe('/middleware/getPersonActivity', () => {
       keywords: filterVals.keywords,
       dateFrom: toIsoDateFromPicker(filterVals.dateFrom),
       dateTo: toIsoDateFromPicker(filterVals.dateTo),
-      filters: ['complied', 'notComplied'],
+      filters: ['complied', 'not complied'],
       includeSystemGenerated: false,
       typeCodes: APPOINTMENTS_CODES,
     }

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,6 @@ export const getComplianceData = (hmppsAuthClient: HmppsAuthClient): Route<Promi`
`37`	`37`	`res.locals.appointmentOutcome.compliance = {`
`38`	`38`	`...res.locals.appointmentOutcome.compliance,`
`39`	`39`	`nonCompliance,`
`40`		`- acceptableAbsenceCount: currentSentenceCompliance?.activity?.acceptableAbsenceCount,`
`41`	`40`	`}`
`42`	`41`	`} else {`
`43`	`42`	`res.locals.appointmentOutcome.compliance = buildCompliance(`
Original file line number	Diff line number	Diff line change
`@@ -175,7 +175,7 @@ describe('/middleware/getPersonActivity', () => {`
`175`	`175`	`keywords: filterVals.keywords,`
`176`	`176`	`dateFrom: toIsoDateFromPicker(filterVals.dateFrom),`
`177`	`177`	`dateTo: toIsoDateFromPicker(filterVals.dateTo),`
`178`		`- filters: ['complied', 'notComplied'],`
	`178`	`+ filters: ['complied', 'not complied'],`
`179`	`179`	`includeSystemGenerated: false,`
`180`	`180`	`typeCodes: APPOINTMENTS_CODES,`
`181`	`181`	`}`