Skip to content
This repository was archived by the owner on Jan 9, 2025. It is now read-only.
This repository was archived by the owner on Jan 9, 2025. It is now read-only.

[Suggestion] Extracting the JS business logic to reduce duplication #104

Open
@stof

Description

@stof

Currently, each method of the ZombieDriver needs to provide its JS business logic. This leads to code duplication. See for instance #103 which needs to be able to select a value for a radio button in 2 different methods.

My suggestion would be to move the business logic to a bunch of functions defined in the script running the zombie server itself. Then, the ZombieDriver would just have to use these functions when needed. This way, we could reuse some code by defining helper functions used by other functions, just like we do in MinkSelenium2Driver with a bunch of private methods in PHP for instance.
what do you think about this approach @aik099 ?

If we go this way, my suggestion would be to do the 1.2 release first (after fixing the tests), and then do the refactoring in a 1.3 release (to let us the time to ensure we don't introduce issues)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions