Remove problematic admin create session endpoint

Author: experimatt

app/controllers/admin/legacy/sessions_controller.rb

@@ -11,10 +11,6 @@ def edit
     respond_with(@session)
   end
 
-  def new
-    respond_with(@session)
-  end
-
   def update
     if @session.update(session_params)
       redirect_to admin_legacy_sessions_path
@@ -23,29 +19,6 @@ def update
     end
   end
 
-  def build_presenter
-    name = params[:session].delete(:name)
-    # find exact match by name
-    Participant.where(name: name).first_or_initialize do |p|
-      p.save(validate: false) if p.new_record?
-    end
-  end
-
-  def create
-    @session.participant = build_presenter
-    @session.attributes = session_params
-    @session.event = Event.current_event
-    @session.timeslot_id = params[:session][:timeslot_id]
-    @session.room_id = params[:session][:room_id]
-
-    if @session.save
-      flash[:notice] = "Presentation added"
-      redirect_to admin_legacy_sessions_path
-    else
-      render :new
-    end
-  end
-
   def destroy
     @session.destroy!
     flash[:notice] = "Session has been deleted"

app/views/admin/legacy/sessions/index.html.erb

@@ -1,7 +1,5 @@
 <% title('Admin: All sessions') %>
 
-<h2><%= link_to 'Add a session', new_admin_legacy_session_path %></h2>
-
 <div class="row">
   <div class="column grid_6" style="margin-left:0px">
    <ul class="sessionsList">

config/routes.rb

@@ -45,7 +45,7 @@
     get '/legacy', to: 'legacy/admin#show', as: :legacy
     namespace :legacy do
       resource :config, only: [:show, :create]
-      resources :sessions
+      resources :sessions, except: [:new, :create]
       resources :markdown_contents, path: 'markdown-contents'
       resources :events do
         resources :timeslots, only: [:index, :new, :create]

spec/controllers/admin/legacy/sessions_controller_spec.rb

@@ -43,48 +43,4 @@
       end
     end
   end
-
-  describe "create" do
-    let!(:event) { create(:event) }
-    let(:category) { Category.last }
-    before do
-      Participant.destroy_all
-      create(:participant, name: "Joe Schmoe")
-    end
-
-    context "with valid values" do
-      it "creates a new session " do
-
-        expect {
-          expect {
-            post :create, params: { session: { title: 'new title', description: 'new description', category_ids: [category.id], level_id: '2', name: "Ada Lovelace"} }
-          }.to change { Session.count }.by(1)
-        }.to change { Participant.count }.by(1)
-        expect(response).to redirect_to admin_legacy_sessions_path
-        expect(assigns[:session].title).to eq 'new title'
-        expect(assigns[:session].participant.name).to eq 'Ada Lovelace'
-        expect(assigns[:session].event).to eq event
-        expect(assigns[:session].category_ids).to include category.id
-        expect(flash[:notice]).to eq "Presentation added"
-      end
-    end
-
-    context "with invalid values" do
-      it "shows the errors" do
-
-        expect {
-          post :create, params: { session: { title: ''} }
-        }.not_to change { Session.count }
-        expect(response).to render_template('new')
-      end
-    end
-  end
-
-  describe "new" do
-    it "should be successful" do
-      get :new
-      expect(response).to be_successful
-      expect(assigns[:session]).to be_kind_of Session
-    end
-  end
 end