Log a repeated validation error reason once

Author: thomas-samoht

app/errors/handlers.py

@@ -30,7 +30,7 @@ def summarize_reason(exc: Exception) -> str:
             f"{'.'.join(str(loc) for loc in err.get('loc', ()))}: {err.get('msg', '')}".strip(" :")
             for err in exc.errors()
         ]
-        return "; ".join(r for r in reasons if r) or "validation error"
+        return "; ".join(dict.fromkeys(r for r in reasons if r)) or "validation error"
     return str(exc)
 
 

tests/routers/test_localization_list.py

@@ -7,6 +7,7 @@
 from app.debug.crypto_service_api_client_mock import CryptoServiceApiClientMock
 from app.logging.events import Log
 from app.models.auth.data import AuthorizationScope
+from app.models.fhir.resources.data import PSEUDONYM_SYSTEM
 from app.models.pseudonym import EncryptedPseudonym
 from app.models.ura import UraNumber
 from app.services.key_info import KeyInfoService
@@ -235,6 +236,15 @@ def test_keeps_the_subject_token_out_of_an_invalid_localization_log(self, locali
         entry = assert_event_emitted(records, Log.INVALID_REQUEST, http_status=422)
         assert "leaky-token-value" not in entry.message["error_reason"]
 
+    def test_logs_an_invalid_subject_token_reason_once(self, localize_client: TestClient) -> None:
+        with capture_records() as records:
+            localize_client.get("/fhir/List", params={"subject:identifier": f"{PSEUDONYM_SYSTEM}|not-a-token"})
+
+        entry = assert_event_emitted(records, Log.INVALID_REQUEST, http_status=422)
+        assert entry.message["error_reason"] == (
+            "query.subject:identifier: Value error, Invalid pseudonym in subject:identifier"
+        )
+
     def test_localize_query_requires_localize_scope(self, client: TestClient) -> None:
         response = client.get("/fhir/List", params={"subject:identifier": TEST_PSEUDONYM_TOKEN})