Skip to content

Commit d7eaefc

Browse files
committed
[#noissue] Replace StringUtils.toString with String.valueOf
1 parent 114e56e commit d7eaefc

File tree

9 files changed

+12
-8
lines changed

9 files changed

+12
-8
lines changed

agent-module/plugins/common-servlet/src/main/java/com/navercorp/pinpoint/plugin/common/servlet/jakarta/util/HttpServletParameterExtractor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ public String extractParameter(HttpServletRequest httpServletRequest) {
7676
}
7777
for (String value : values) {
7878
if (value != null) {
79-
params.append(StringUtils.abbreviate(StringUtils.toString(value), eachLimit));
79+
params.append(StringUtils.abbreviate(value, eachLimit));
8080
}
8181
}
8282
}

agent-module/plugins/common-servlet/src/main/java/com/navercorp/pinpoint/plugin/common/servlet/util/HttpServletParameterExtractor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ public String extractParameter(HttpServletRequest httpServletRequest) {
7676
}
7777
for (String value : values) {
7878
if (value != null) {
79-
params.append(StringUtils.abbreviate(StringUtils.toString(value), eachLimit));
79+
params.append(StringUtils.abbreviate(value, eachLimit));
8080
}
8181
}
8282
}

agent-module/plugins/reactor-netty/src/main/java/com/navercorp/pinpoint/plugin/reactor/netty/interceptor/HttpServerParameterExtractor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ public String extractParameter(HttpServerRequest request) {
6767
// append value
6868
String value = entry.getValue();
6969
if (value != null) {
70-
params.append(StringUtils.abbreviate(StringUtils.toString(value), eachLimit));
70+
params.append(StringUtils.abbreviate(value, eachLimit));
7171
}
7272
}
7373
return params.toString();

agent-module/plugins/undertow/src/main/java/com/navercorp/pinpoint/plugin/undertow/HttpServerExchangeParameterExtractor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ public String extractParameter(HttpServerExchange request) {
6565
}
6666
for (String value : values) {
6767
if (value != null) {
68-
params.append(StringUtils.abbreviate(StringUtils.toString(value), eachLimit));
68+
params.append(StringUtils.abbreviate(value, eachLimit));
6969
}
7070
}
7171
}

agent-module/plugins/vertx/src/main/java/com/navercorp/pinpoint/plugin/vertx/HttpServerParameterExtractor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public String extractParameter(HttpServerRequest request) {
5959
params.append('=');
6060
Object value = entry.getValue();
6161
if (value != null) {
62-
params.append(StringUtils.abbreviate(StringUtils.toString(value), eachLimit));
62+
params.append(StringUtils.abbreviate(String.valueOf(value), eachLimit));
6363
}
6464
}
6565
return params.toString();

agent-module/plugins/weblogic/src/main/java/com/navercorp/pinpoint/plugin/weblogic/ServletRequestImplParameterExtractor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public String extractParameter(ServletRequestImpl request) {
6262
params.append('=');
6363
final String value = attrs.getValue();
6464
if (value != null) {
65-
params.append(StringUtils.abbreviate(StringUtils.toString(value), eachLimit));
65+
params.append(StringUtils.abbreviate(value, eachLimit));
6666
}
6767
}
6868
} catch (UnsupportedEncodingException ignored) {

agent-module/plugins/websphere/src/main/java/com/navercorp/pinpoint/plugin/websphere/IRequestParameterExtractor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public String extractParameter(IRequest request) {
6060
params.append('=');
6161
String value = entry.getValue();
6262
if (value != null) {
63-
params.append(StringUtils.abbreviate(StringUtils.toString(value), eachLimit));
63+
params.append(StringUtils.abbreviate(value, eachLimit));
6464
}
6565
}
6666
} catch (UnsupportedEncodingException ignored) {

agent-module/profiler/src/main/java/com/navercorp/pinpoint/profiler/jdbc/SimpleTypeConverter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,6 @@ public String convert(Object value) {
5555

5656

5757
private String abbreviate(Object arg) {
58-
return StringUtils.abbreviate(StringUtils.toString(arg), this.maxWidth);
58+
return StringUtils.abbreviate(String.valueOf(arg), this.maxWidth);
5959
}
6060
}

commons/src/main/java/com/navercorp/pinpoint/common/util/StringUtils.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,10 @@ public static int getLength(final String string, final int nullValue) {
7676
return string.length();
7777
}
7878

79+
/**
80+
* alternative to {@link String#valueOf(Object)}
81+
*/
82+
@Deprecated
7983
public static String toString(final Object object) {
8084
if (object == null) {
8185
return NULL_STRING;

0 commit comments

Comments
 (0)