Jams duration for symbolic datasets #450
rabitt
started this conversation in
API Design
Replies: 2 comments
-
|
I'm not too familiar with symbolic datasets, If |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
Just to link them, the outcome of this depends on what we decide with #298 ! |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
We currently require Track objects to have a jams_converter method, which is required to generate jams objects which validate. In order for the jams object to validate, it needs to have a "duration" passed. For some symbolic datasets, this doesn't make as much sense, and the jams format in general is not build with symbolic data in mind. Some ideas for solutions:
SymbolicTrack.@PRamoneda and @nkundiushuti - I think solution 1 is the simplest, but maybe there's other custom things we want to make consistent for all symbolic data. Or do you think the current Track object is fine?
As a temporary patch, for symbolic datasets we can put a dummy value for duration, like 1.
Thanks @PRamoneda and @nkundiushuti for bringing this issue up!
Beta Was this translation helpful? Give feedback.
All reactions