Merge pull request #221 from miroiu/fix/220-connection-overrides

Fixed overrides of arrowhead virtual methods not working for connections

Author: miroiu

CHANGELOG.md

@@ -7,6 +7,7 @@
 >	- Added AsRef extension method to InputGesture to convert it to an InputGestureRef
 > - Bugfixes:
 >	- Fixed an issue where the gesture used for EditorGestures.Editor.SelectAll extracted from the ApplicationCommands was assumed to be a KeyGesture
+>	- Fixed overrides of DrawDefaultArrowhead and DrawDirectionalArrowheadGeometry virtual methods not working in subclasses of the built in connections
 
 #### **Version 7.0.3**
 

Nodify/Connections/CircuitConnection.cs

@@ -82,7 +82,7 @@ protected override void DrawDirectionalArrowsGeometry(StreamGeometryContext cont
                 var (segment, to) = InterpolateLine(p0, p1, p2, t);
 
                 var direction = segment.SegmentStart - segment.SegmentEnd;
-                base.DrawDirectionalArrowheadGeometry(context, direction, to);
+                DrawDirectionalArrowheadGeometry(context, direction, to);
             }
         }
 

Nodify/Connections/Connection.cs

@@ -42,7 +42,7 @@ protected override void DrawDirectionalArrowsGeometry(StreamGeometryContext cont
                 var to = InterpolateCubicBezier(p0, p1, p2, p3, t);
                 var direction = GetBezierTangent(p0, p1, p2, p3, t);
 
-                base.DrawDirectionalArrowheadGeometry(context, direction, to);
+                DrawDirectionalArrowheadGeometry(context, direction, to);
             }
         }
 

Nodify/Connections/LineConnection.cs

@@ -68,7 +68,7 @@ protected override void DrawDefaultArrowhead(StreamGeometryContext context, Poin
             }
             else
             {
-                base.DrawDefaultArrowhead(context, source, target, arrowDirection, orientation);
+                DrawDefaultArrowhead(context, source, target, arrowDirection, orientation);
             }
         }
 
@@ -83,7 +83,7 @@ protected override void DrawDirectionalArrowsGeometry(StreamGeometryContext cont
                 double t = (spacing * i + DirectionalArrowsOffset).WrapToRange(0d, 1d);
                 var to = InterpolateLineSegment(p0, p1, t);
 
-                base.DrawDirectionalArrowheadGeometry(context, direction, to);
+                DrawDirectionalArrowheadGeometry(context, direction, to);
             }
         }
 

Nodify/Connections/StepConnection.cs

@@ -163,7 +163,7 @@ protected override void DrawDirectionalArrowsGeometry(StreamGeometryContext cont
                 var (segment, to) = InterpolateLine(p0, p1, p2, p3, t);
 
                 var direction = segment.SegmentStart - segment.SegmentEnd;
-                base.DrawDirectionalArrowheadGeometry(context, direction, to);
+                DrawDirectionalArrowheadGeometry(context, direction, to);
             }
         }