Skip to content

Factor common schema directives logic used by make_executable_schema from SchemaDirectiveVisitor #1018

Open
@rafalp

Description

@rafalp

Currently SchemaDirectiveVisitor does two things:

  • Its a base class for custom GraphQL directives.
  • Its a manager class for directives, with visit_schema_directives and get_declared_directives classmethods that make_executable_schema uses to apply directives to the schema

We should introduce new abstraction called SchemaDirective that extends SchemaVisitor, but only adds directive-specific logic, and move management/schema visiting logic to utility functions. SchemaDirectiveVisitor should then be deprecated.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions