Skip to content

ariadne.wsgi.GraphQL.get_request_data declares dict as return type but doesn't check for it. #1028

Open
@rafalp

Description

@rafalp

get_request_data calls extract_data_from_json_request that returns Any which is then casted to dict without any verification of it's type.

This verification still happens in graphql_sync so we are covered, but currently type is lying to developers working with the code.

We should change it's return type to Any and update the docs to reflect this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingto do

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions