-
Notifications
You must be signed in to change notification settings - Fork 25
Expand file tree
/
Copy pathtest_dataclass_conversion.py
More file actions
502 lines (419 loc) · 12.1 KB
/
Copy pathtest_dataclass_conversion.py
File metadata and controls
502 lines (419 loc) · 12.1 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
# Copyright (c) 2026 Massachusetts Institute of Technology
# SPDX-License-Identifier: MIT
from dataclasses import MISSING, InitVar, dataclass, field
from pathlib import Path
from typing import Any, Callable, TypeVar
import hypothesis.strategies as st
import pytest
from hypothesis import given
from omegaconf import OmegaConf
from typing_extensions import TypeAlias
from hydra_zen import (
ZenField,
builds,
hydrated_dataclass,
instantiate,
just,
make_config,
make_custom_builds_fn,
mutable_value,
)
from hydra_zen.errors import HydraZenUnsupportedPrimitiveError
from hydra_zen.structured_configs._implementations import (
_resolve_field_default,
_value_contains_builds,
)
from hydra_zen.structured_configs._type_guards import is_builds
from hydra_zen.typing import Builds
from hydra_zen.typing._implementations import DataClass_, InstOrType, ZenConvert
from .test_just import list_of_objects
TDataClass = InstOrType[DataClass_]
T = TypeVar("T")
Interface1: TypeAlias = Callable[[int], int]
Interface2: TypeAlias = Callable[[str], str]
@dataclass
class Nested:
x: Any
def foo(i: int) -> int:
return i
def bar(s: str) -> str:
return s
def baz(f: float) -> float:
return f
@dataclass
class Stuff:
field1: Interface1
field2: Interface2
field3: Nested = mutable_value(Nested(baz))
field4: Any = field(default_factory=lambda: [1, 2, 3])
@pytest.mark.parametrize("via_just", [True, False])
def test_293_proposal(via_just: bool):
# https://github.com/mit-ll-responsible-ai/hydra-zen/discussions/293
foobar = Stuff(foo, bar, Nested(baz))
BuildsFooBar2 = (
just(foobar)
if via_just
else builds(Stuff, field1=foo, field2=bar, populate_full_signature=True)
)
inst = instantiate(BuildsFooBar2)
assert isinstance(inst, Stuff)
assert inst == foobar
assert (
OmegaConf.to_yaml(BuildsFooBar2)
== """\
_target_: tests.test_dataclass_conversion.Stuff
field1:
path: tests.test_dataclass_conversion.foo
_target_: hydra_zen.funcs.get_obj
field2:
path: tests.test_dataclass_conversion.bar
_target_: hydra_zen.funcs.get_obj
field3:
_target_: tests.test_dataclass_conversion.Nested
x:
path: tests.test_dataclass_conversion.baz
_target_: hydra_zen.funcs.get_obj
field4:
- 1
- 2
- 3
"""
)
list_of_objects = [
1,
None,
True,
1 + 2j,
"hi",
b"hi",
dict(a=1),
[1, 2],
Path().home(),
Stuff,
Stuff(foo, bar, Nested(baz)),
]
def test_recursive_manual():
Conf = just(Nested(Nested(Nested)))
assert just(Conf) is Conf
out = instantiate(Conf)
assert isinstance(out, Nested)
assert isinstance(out.x, Nested)
assert out.x.x is Nested
@given(
st.recursive(
st.sampled_from(list_of_objects), lambda x: st.builds(Nested, x), max_leaves=5
)
)
def test_recursive_conversion(x):
if not isinstance(x, Nested):
x = Nested(x)
assert instantiate(just(x)) == x
assert instantiate(builds(Nested, x=x.x)) == x
assert instantiate(OmegaConf.create(OmegaConf.to_yaml(just(x)))) == x
@dataclass
class _Inner858:
x: int = 0
@dataclass
class _OuterDict858:
outer: "dict[str, _Inner858]"
@dataclass
class _OuterList858:
outer: "list[_Inner858]"
@dataclass
class _OuterNested858:
outer: "dict[str, list[_Inner858]]"
@pytest.mark.parametrize(
"obj",
[
_OuterDict858(outer={"a": _Inner858(x=1)}),
_OuterList858(outer=[_Inner858(x=1)]),
_OuterNested858(outer={"a": [_Inner858(x=1), _Inner858(x=2)]}),
],
)
def test_just_on_container_field_of_typed_dataclasses(obj):
# https://github.com/mit-ll-responsible-ai/hydra-zen/issues/858
# A dataclass whose field is annotated with a container of a dataclass type
# (e.g. `dict[str, Inner]`) used to fail to convert to yaml because the field's
# values get converted to `Builds_Inner` configs while the field's annotation
# retained the original (non-builds) element type, which OmegaConf rejects.
Conf = just(obj)
# must not raise omegaconf.errors.ValidationError
assert instantiate(OmegaConf.create(OmegaConf.to_yaml(Conf))) == obj
def test_value_contains_builds():
# https://github.com/mit-ll-responsible-ai/hydra-zen/issues/858
cfg = just(_Inner858(x=1))
assert is_builds(cfg)
assert _value_contains_builds(cfg) is True
assert _value_contains_builds([0, cfg]) is True
assert _value_contains_builds({"a": cfg}) is True
assert _value_contains_builds({"a": [cfg]}) is True
assert _value_contains_builds([1, 2, 3]) is False
assert _value_contains_builds({"a": 1}) is False
assert _value_contains_builds("not a container") is False
def test_resolve_field_default():
# https://github.com/mit-ll-responsible-ai/hydra-zen/issues/858
# plain default
assert _resolve_field_default(field(default=1)) == 1
# default_factory is resolved to its produced value
assert _resolve_field_default(field(default_factory=lambda: [1, 2])) == [1, 2]
# no default and no factory -> MISSING
assert _resolve_field_default(field()) is MISSING
@dataclass
class NoDefault:
x: Any
@dataclass
class HasDefault:
x: Any = 1
@dataclass
class HasDefaultFactory:
x: Any = field(default_factory=lambda: [1 + 2j, "a", 3])
@dataclass
class HasNonInit:
x: float
y: float = field(init=False)
def __post_init__(self):
self.y = self.x * 2
@dataclass
class HasInitVarNoDefault:
x: InitVar[Any]
@dataclass
class HasInitVarWithDefault:
x: InitVar[Any] = 22
@pytest.mark.parametrize(
"dataclass_inst",
[
NoDefault(x=1),
HasDefault(),
HasDefaultFactory(),
HasDefaultFactory([Path.home(), 2 - 4j]),
HasNonInit(x=22),
],
)
def test_flavors_of_dataclasses(dataclass_inst):
Config = just(dataclass_inst)
inst = instantiate(Config)
assert isinstance(inst, type(dataclass_inst))
assert inst.x == dataclass_inst.x
@pytest.mark.parametrize(
"dataclass_inst",
[
HasInitVarNoDefault(x=1),
HasInitVarWithDefault(),
],
)
def test_just_raises_on_initvar_field(dataclass_inst):
with pytest.raises(HydraZenUnsupportedPrimitiveError):
just(dataclass_inst)
@pytest.mark.parametrize(
"dataclass_type",
[
HasInitVarNoDefault,
HasInitVarWithDefault,
],
)
def test_builds_with_initvar_field(dataclass_type):
assert instantiate(
builds(dataclass_type, populate_full_signature=True), x=1
) == dataclass_type(x=1)
def _zen_get(obj):
x = obj.default.default
return x if x is not MISSING else obj.default.default_factory()
@pytest.mark.parametrize(
"dataclass_obj",
[
NoDefault(x=1),
HasDefault(),
HasDefaultFactory(),
HasDefaultFactory([Path.home(), 2 - 4j]),
HasNonInit(x=22),
builds(int)(),
NoDefault,
HasDefault,
HasDefaultFactory,
HasDefaultFactory,
HasNonInit,
builds(int),
],
)
@pytest.mark.parametrize(
"config_maker",
[
lambda x: make_config(x=x)().x,
lambda x: builds(dict, x=x, zen_convert={"dataclass": False})().x,
lambda x: make_custom_builds_fn(zen_convert={"dataclass": False})(
dict, x=x
)().x,
lambda x: just(x, zen_convert={"dataclass": False}),
lambda x: _zen_get(
ZenField(default=x, name="x", zen_convert={"dataclass": False})
),
],
)
def test_no_dataclass_conversion(
config_maker: Callable[[TDataClass], TDataClass], dataclass_obj: TDataClass
):
assert config_maker(dataclass_obj) is dataclass_obj
@pytest.mark.parametrize(
"dataclass_obj",
[
NoDefault(x=1),
HasDefault(),
HasDefaultFactory(),
HasDefaultFactory([Path.home(), 2 - 4j]),
HasNonInit(x=22),
NoDefault,
HasDefault,
HasDefaultFactory,
HasDefaultFactory,
HasNonInit,
],
)
@pytest.mark.parametrize(
"config_maker",
[
lambda x: make_config(x=x, zen_convert={"dataclass": True})().x,
lambda x: make_custom_builds_fn(zen_convert={"dataclass": True})(dict, x=x)().x,
lambda x: builds(dict, x=x)().x,
lambda x: just(x),
lambda x: _zen_get(
ZenField(
default=x,
name="x",
)
),
],
)
def test_yes_dataclass_conversion(
config_maker: Callable[[TDataClass], Builds[type[TDataClass]]],
dataclass_obj: TDataClass,
):
out = config_maker(dataclass_obj)
inst_out = instantiate(out)
assert out is not dataclass_obj
assert is_builds(out)
assert isinstance(inst_out, type(dataclass_obj))
assert inst_out == dataclass_obj
def identity(x):
return x
def test_builds_with_positional_arg():
out1 = instantiate(
builds(
identity,
HasDefault(),
hydra_convert="all",
zen_convert={"dataclass": True},
)
)
assert isinstance(out1, HasDefault) and out1 == HasDefault()
out2 = instantiate(
builds(
identity,
HasDefault(),
hydra_convert="all",
zen_convert={"dataclass": False},
)
)
assert not isinstance(out2, HasDefault)
@pytest.mark.parametrize(
"dataclass_obj",
[
NoDefault(x=1),
HasDefault(),
HasDefaultFactory(),
HasDefaultFactory([Path.home(), 2 - 4j]),
HasNonInit(x=22),
NoDefault,
HasDefault,
HasDefaultFactory,
HasDefaultFactory,
HasNonInit,
],
)
@pytest.mark.parametrize(
"config_maker",
[
lambda x: make_config(x=x, zen_convert={"dataclass": True})().x,
lambda x: builds(dict, x=x)().x,
lambda x: make_custom_builds_fn()(dict, x=x)().x,
lambda x: just(x),
lambda x: ZenField(
default=x,
name="x",
).default.default_factory(), # type: ignore
],
)
@pytest.mark.parametrize(
"as_container",
[
lambda dataclass_obj: [0, dataclass_obj],
lambda dataclass_obj: {1: dataclass_obj},
],
)
def test_recursive_dataclass_conversion(
config_maker: Callable[[list[TDataClass]], list[Builds[type[TDataClass]]]],
dataclass_obj: TDataClass,
as_container: Callable[[T], list[T]],
):
out = config_maker(as_container(dataclass_obj))[1] # type: ignore
inst_out = instantiate(out)
assert out is not dataclass_obj
assert is_builds(out)
assert isinstance(inst_out, type(dataclass_obj))
assert inst_out == dataclass_obj
@pytest.mark.parametrize("obj", [make_config(), make_config()()])
def test_just_auto_config_raises_on_dynamically_generated_types(obj):
with pytest.raises(HydraZenUnsupportedPrimitiveError):
just(obj)
@dataclass
class A:
y: int = 1
A_dictconfig = instantiate(A)
@pytest.mark.parametrize(
"config, expected",
[
(
builds(dict, x=A()),
dict(x=A()),
),
(
builds(dict, x=A(), zen_convert=ZenConvert(dataclass=True)),
dict(x=A()),
),
(
builds(dict, x=A(), zen_convert=ZenConvert(dataclass=False)),
dict(x=A_dictconfig),
),
(
make_config(
x=A(), zen_convert=ZenConvert(dataclass=True), hydra_convert="all"
),
dict(x=A()),
),
(
make_config(
x=A(),
zen_convert=ZenConvert(dataclass=False),
),
dict(x=A_dictconfig),
),
],
)
def test_zen_convert(config, expected):
actual = instantiate(config)
assert actual == expected
assert isinstance(actual["x"], type(expected["x"]))
def f(x=HasDefault()):
return x
def test_hydrated_dataclass():
@hydrated_dataclass(f, populate_full_signature=True)
class A: ...
@hydrated_dataclass(
f, populate_full_signature=True, zen_convert={"dataclass": False}
)
class B: ...
out_a = instantiate(A)
assert isinstance(out_a, HasDefault)
assert out_a == HasDefault()
out_b = instantiate(B)
assert not isinstance(out_b, HasDefault)
assert out_b == HasDefault()