Fix URL normalization

Author: tchajed

opam/opam_file.go

@@ -39,7 +39,7 @@ type PinDepend struct {
 // Returns dep.
 func (dep *PinDepend) Normalize() *PinDepend {
 	dep.Package = strings.TrimSuffix(dep.Package, ".dev")
-	if strings.HasPrefix("https://", dep.URL) {
+	if strings.HasPrefix(dep.URL, "https://") {
 		dep.URL = "git+" + dep.URL
 	}
 	return dep

opam/opam_file_test.go

@@ -177,13 +177,23 @@ func TestAddPinDepend_Update(t *testing.T) {
 	assert.True(t, found, "perennial not found after update")
 }
 
+func TestNormalize(t *testing.T) {
+	dep := PinDepend{
+		Package: "new-package",
+		URL:     "https://example.com/package",
+		Commit:  "abc123",
+	}
+	dep.Normalize()
+	assert.Equal(t, "git+https://example.com/package", dep.URL)
+}
+
 func TestAddPinDepend_Add(t *testing.T) {
 	f := parseString(t, exampleOpam)
 
 	// Add new dependency
 	f.AddPinDepend(PinDepend{
 		Package: "new-package",
-		URL:     "git+https://example.com/package",
+		URL:     "https://example.com/package",
 		Commit:  "abc123",
 	})