Fix all diagram containment issues and add documentation

- Removed redundant classDef space and class definitions from all diagrams
- Fixed Minikube Architecture, Debug Container Approach, Sidecar Approach diagrams
- Updated contributing documentation with guidelines for proper subgraph containment
- Added detailed instructions on how to ensure proper wrapping of elements
- Documented the need to exclude explicit text color from subgraph labels
- Ensured consistent styling across all diagrams

Signed-off-by: Aaron Lippold <[email protected]>

Author: aaronlippold

docs/contributing/diagram-color-guide.md

@@ -70,11 +70,39 @@ flowchart TD
 When creating Mermaid diagrams, use the following style properties:
 
 ```
-style NodeID fill:#HexColor,stroke:#FFFFFF,stroke-width:2px,color:#FFFFFF,font-weight:bold
+style NodeID fill:#HexColor,stroke:#FFFFFF,stroke-width:2px,color:#FFFFFF
 ```
 
 For light mode compatibility, white text (#FFFFFF) works well with all the recommended background colors.
 
+### Proper Subgraph Containment
+
+When using subgraphs in Mermaid diagrams, follow these guidelines to ensure proper containment and wrapping:
+
+1. **Always add `direction TB` inside subgraphs**: This ensures proper containment of elements within the subgraph
+   
+   ```mermaid
+   flowchart TD
+     subgraph MySubgraph["My Subgraph Title"]
+       direction TB
+       A --> B
+       B --> C
+     end
+   ```
+
+2. **Avoid using `classDef space` and `class` definitions** in your diagrams, as these can interfere with proper rendering and containment. Instead, rely on the default sizing and standard styling.
+
+3. **Consistent styling for subgraphs**:
+   ```
+   style subgraphID fill:none,stroke:#DD6100,stroke-width:4px
+   ```
+   
+4. **Remove explicit text color and font-weight from subgraph labels** to allow for automatic theme handling:
+   - Do NOT use: `style subgraphID fill:none,stroke:#DD6100,stroke-width:4px,color:#FFFFFF,font-weight:bold`
+   - Instead use: `style subgraphID fill:none,stroke:#DD6100,stroke-width:4px`
+
+These guidelines help ensure that subgraphs display correctly in both light and dark modes, with proper containment and wrapping of their elements.
+
 ## Dark Mode Considerations
 
 Our CSS and JavaScript configuration ensures that diagrams display properly in dark mode by:

docs/overview/mermaid-diagrams.md

@@ -48,9 +48,6 @@ flowchart TD
     style rbac fill:#0066CC,stroke:#FFFFFF,stroke-width:2px,color:#FFFFFF
     style saf fill:#0066CC,stroke:#FFFFFF,stroke-width:2px,color:#FFFFFF
 
-    %% Add more vertical space
-    classDef space height:20px;
-    class MiniKubeCluster,ControlNode,WorkerNode1,WorkerNode2 space;
 ```
 
 ## Kubernetes API Approach Workflow
@@ -138,9 +135,6 @@ flowchart TD
     style process fill:#217645,stroke:#FFFFFF,stroke-width:2px,color:#FFFFFF
     style terminate fill:#505050,stroke:#FFFFFF,stroke-width:2px,color:#FFFFFF
     
-    %% Add more vertical space
-    classDef space height:20px;
-    class step1,step2 space;
 ```
 
 ## Sidecar Approach Workflow
@@ -186,10 +180,6 @@ flowchart TD
     style store_results fill:#4C366B,stroke:#FFFFFF,stroke-width:2px,color:#FFFFFF
     style process_results fill:#217645,stroke:#FFFFFF,stroke-width:2px,color:#FFFFFF
     style retrieve_results fill:#4C366B,stroke:#FFFFFF,stroke-width:2px,color:#FFFFFF
-    
-    %% Add more vertical space
-    classDef space height:20px;
-    class step1,step2 space;
 ```
 
 ## Enhanced Kubernetes API Approach Workflow
@@ -296,10 +286,6 @@ flowchart TD
     style process fill:#217645,stroke:#FFFFFF,stroke-width:2px,color:#FFFFFF
     style copy_results fill:#4C366B,stroke:#FFFFFF,stroke-width:2px,color:#FFFFFF
     style cleanup fill:#505050,stroke:#FFFFFF,stroke-width:2px,color:#FFFFFF
-    
-    %% Add more vertical space
-    classDef space height:20px;
-    class stage1,stage2,stage3 space;
 ```
 
 ## GitLab CI Sidecar Approach
@@ -351,10 +337,6 @@ flowchart TD
     style retrieve fill:#505050,stroke:#FFFFFF,stroke-width:2px,color:#FFFFFF
     style process fill:#217645,stroke:#FFFFFF,stroke-width:2px,color:#FFFFFF
     style upload fill:#4C366B,stroke:#FFFFFF,stroke-width:2px,color:#FFFFFF
-    
-    %% Add more vertical space
-    classDef space height:20px;
-    class stage1,stage2,stage3 space;
 ```
 
 ## GitHub Actions Kubernetes API Approach
@@ -406,10 +388,6 @@ flowchart TD
     style run_cinc fill:#217645,stroke:#FFFFFF,stroke-width:2px,color:#FFFFFF
     style process fill:#217645,stroke:#FFFFFF,stroke-width:2px,color:#FFFFFF
     style generate_reports fill:#4C366B,stroke:#FFFFFF,stroke-width:2px,color:#FFFFFF
-    
-    %% Add more vertical space
-    classDef space height:20px;
-    class step1,step2,step3 space;
 ```
 
 ## GitHub Actions Sidecar Approach