#251 not completely fixed, queries with underscore still not recognized

[ralfjunker]

Commit 5d52d32 does not fix the problem with underscores added as a comment to #251.

The following URLs are valid but still not recognized as of version 0.5.3:

• Query with leading underscore: http://a.b/?_c
• Query with trailing underscore: http://a.b/?c_
• Query with underscore before equals sign: http://a.b/?c_=d
• Query with underscore after equals sign: http://a.b/?c=_d

There might be other combinations.

[mity]

Yeah, I've overlooked the comment somehow, sorry for that. I'll take a look at it.

That said, expect very slow and incremental relaxation of the rules in general, I'm quite afraid to make the rules too relaxed in order not to open gates for false positives.

[ralfjunker]

Thanks, @mity, for looking at the underscore issue.

I understand you being careful about relaxing URL detection. However, worries for underscores are unwarranted IMO. The HTML spec lists underscore as part of the URL code points, which make up the URL-query string.

In conclusion, underscores are allowed anywhere in the URL-query string.