Address review comments for #10209

- Rephrase comment: 'free tracks' -> 'independently added tracks'
- Simplify block comment in early-return path
- Fix order: changeScannerState(IDLE) before emit scanSummary()
- Add default constructor to LibraryScanResultSummary instead
  of using in-class initializer for noDirectoriesConfigured

Author: Swarnadip-Kar

src/library/library_decl.h

@@ -21,6 +21,17 @@ enum class FocusWidget {
 };
 
 struct LibraryScanResultSummary {
+    LibraryScanResultSummary()
+            : autoscan(false),
+              numNewTracks(0),
+              numMovedTracks(0),
+              numMissingTracks(0),
+              numNewMissingTracks(0),
+              numRediscoveredTracks(0),
+              tracksTotal(0),
+              noDirectoriesConfigured(false) {
+    }
+
     QString durationString;
     bool autoscan;
     int numNewTracks;
@@ -29,5 +40,5 @@ struct LibraryScanResultSummary {
     int numNewMissingTracks;
     int numRediscoveredTracks;
     int tracksTotal;
-    bool noDirectoriesConfigured = false;
+    bool noDirectoriesConfigured;
 };

src/library/scanner/libraryscanner.cpp

@@ -192,26 +192,17 @@ void LibraryScanner::slotStartScan() {
 
     // Recursively scan each directory in the directories table.
     m_libraryRootDirs = m_directoryDao.loadAllDirectories();
-    // If there are no directories then we still have to scan free tracks.
+    // If there are no directories then we still have to scan independently added tracks.
     QSet<QString> trackLocations = m_trackDao.getAllTrackLocations();
 
     if (m_libraryRootDirs.isEmpty() && trackLocations.isEmpty()) {
-        // Show the "no dirs" message if m_libraryRootDirs and trackLocations
-        // are both empty. m_libraryRootDirs includes missing tracks, so if that
-        // is empty, there's indeed nothing to do.
+        // Nothing to do. noDirectoriesConfigured == true will show the "no dirs" message.
         LibraryScanResultSummary result;
-        result.durationString = ""; // Explicitly kept empty as no scan was performed.
-        result.numNewTracks = 0;
-        result.numMovedTracks = m_numRelocatedTracks;
-        result.numNewMissingTracks = 0;
-        result.numMissingTracks = 0;
-        result.numRediscoveredTracks = 0;
-        result.tracksTotal = 0;
         result.autoscan = m_manualScan;
         result.noDirectoriesConfigured = true;
 
-        emit scanSummary(result);
         changeScannerState(IDLE);
+        emit scanSummary(result);
         return;
     }
     changeScannerState(SCANNING);