TEST: update track table after applying new date format in preferences

Author: ronso0

src/library/basetracktablemodel.cpp

@@ -111,15 +111,38 @@ void BaseTrackTableModel::setKeyColorPalette(const ColorPalette& palette) {
 bool BaseTrackTableModel::s_bApplyPlayedTrackColor =
         kApplyPlayedTrackColorDefault;
 
+// static
 void BaseTrackTableModel::setApplyPlayedTrackColor(bool apply) {
     s_bApplyPlayedTrackColor = apply;
 }
 
 const QString BaseTrackTableModel::kDateFormatDefault = QString();
 QString BaseTrackTableModel::s_dateFormat = BaseTrackTableModel::kDateFormatDefault;
 
+// static
 void BaseTrackTableModel::setDateFormat(const QString& format) {
     s_dateFormat = format;
+    emit broadcaster()->dateFormatChanged();
+}
+
+void BaseTrackTableModel::slotEmitDataChangedForDateColumns() {
+    // Notify the view to update.
+    // These are the columns that use s_dateFormat
+    QList<int> columns;
+    columns.append(fieldIndex(ColumnCache::COLUMN_LIBRARYTABLE_DATETIMEADDED));
+    columns.append(fieldIndex(ColumnCache::COLUMN_PLAYLISTTRACKSTABLE_DATETIMEADDED));
+    columns.append(fieldIndex(ColumnCache::COLUMN_LIBRARYTABLE_LAST_PLAYED_AT));
+    const QVector<int> roles{Qt::DisplayRole};
+    QModelIndex topLeft;
+    QModelIndex bottomRight;
+    for (int i : columns) {
+        if (i == -1) {
+            continue;
+        }
+        topLeft = index(0, i);
+        bottomRight = index(rowCount() - 1, i);
+        emit dataChanged(topLeft, bottomRight, roles);
+    }
 }
 
 BaseTrackTableModel::BaseTrackTableModel(
@@ -148,6 +171,10 @@ BaseTrackTableModel::BaseTrackTableModel(
                 this,
                 &BaseTrackTableModel::slotCoverFound);
     }
+    connect(broadcaster(),
+            &DateFormatChangedBroadcaster::dateFormatChanged,
+            this,
+            &BaseTrackTableModel::slotEmitDataChangedForDateColumns);
 }
 
 void BaseTrackTableModel::initTableColumnsAndHeaderProperties(

src/library/basetracktablemodel.h

@@ -13,6 +13,14 @@
 
 class TrackCollectionManager;
 
+/// Broadcaster (singleton) that instances connect to in order to
+/// refresh columns using static s_dateFormat after a new format has been set
+class DateFormatChangedBroadcaster : public QObject {
+    Q_OBJECT
+  signals:
+    void dateFormatChanged();
+};
+
 /// Base class for tabular track list views.
 ///
 /// The abstract model behind `WTrackTableView`.
@@ -280,6 +288,8 @@ class BaseTrackTableModel : public QAbstractTableModel, public TrackModel {
             const CoverInfo& coverInfo,
             const QPixmap& pixmap);
 
+    void slotEmitDataChangedForDateColumns();
+
   private:
     QVariant rawSiblingValue(
             const QModelIndex& index,
@@ -300,6 +310,11 @@ class BaseTrackTableModel : public QAbstractTableModel, public TrackModel {
     QList<QUrl> collectUrls(
             const QModelIndexList& indexes) const;
 
+    static DateFormatChangedBroadcaster* broadcaster() {
+        static DateFormatChangedBroadcaster instance;
+        return &instance;
+    }
+
     const QString m_previewDeckGroup;
 
     double m_backgroundColorOpacity;