TEST: add DateFormatChangedBroadcaster to force-update track table views

Author: ronso0

CMakeLists.txt

@@ -1388,6 +1388,7 @@ add_library(
   src/library/coverart.cpp
   src/library/coverartcache.cpp
   src/library/coverartutils.cpp
+  src/library/dateformatbroadcaster.cpp
   src/library/dao/analysisdao.cpp
   src/library/dao/autodjcratesdao.cpp
   src/library/dao/cuedao.cpp

src/library/basetracktablemodel.cpp

@@ -9,6 +9,7 @@
 #include "base/Pitch.h"
 #include "library/coverartcache.h"
 #include "library/dao/trackschema.h"
+#include "library/dateformatbroadcaster.h"
 #include "library/starrating.h"
 #include "library/tabledelegates/bpmdelegate.h"
 #include "library/tabledelegates/checkboxdelegate.h"
@@ -111,15 +112,42 @@ void BaseTrackTableModel::setKeyColorPalette(const ColorPalette& palette) {
 bool BaseTrackTableModel::s_bApplyPlayedTrackColor =
         kApplyPlayedTrackColorDefault;
 
+// static
 void BaseTrackTableModel::setApplyPlayedTrackColor(bool apply) {
     s_bApplyPlayedTrackColor = apply;
 }
 
 const QString BaseTrackTableModel::kDateFormatDefault = QString();
 QString BaseTrackTableModel::s_dateFormat = BaseTrackTableModel::kDateFormatDefault;
 
+// static
 void BaseTrackTableModel::setDateFormat(const QString& format) {
-    s_dateFormat = format;
+    if (format != s_dateFormat) {
+        s_dateFormat = format;
+        auto* broadcaster = DateFormatChangedBroadcaster::instance();
+        emit broadcaster->dateFormatChanged();
+    }
+}
+
+void BaseTrackTableModel::slotEmitDataChangedForDateColumns() {
+    // Notify the view to update.
+    // These are the columns that use s_dateFormat
+    QList<int> columns;
+    columns.append(fieldIndex(ColumnCache::COLUMN_LIBRARYTABLE_DATETIMEADDED));
+    columns.append(fieldIndex(ColumnCache::COLUMN_PLAYLISTTRACKSTABLE_DATETIMEADDED));
+    columns.append(fieldIndex(ColumnCache::COLUMN_LIBRARYTABLE_LAST_PLAYED_AT));
+    const QVector<int> roles{Qt::DisplayRole};
+    QModelIndex topLeft;
+    QModelIndex bottomRight;
+    for (int i : columns) {
+        if (i == -1) {
+            // Skip if a certain model doesn't have this column
+            continue;
+        }
+        topLeft = index(0, i);
+        bottomRight = index(rowCount() - 1, i);
+        emit dataChanged(topLeft, bottomRight, roles);
+    }
 }
 
 BaseTrackTableModel::BaseTrackTableModel(
@@ -148,6 +176,12 @@ BaseTrackTableModel::BaseTrackTableModel(
                 this,
                 &BaseTrackTableModel::slotCoverFound);
     }
+
+    auto* dateFormatBroadcaster = DateFormatChangedBroadcaster::instance();
+    connect(dateFormatBroadcaster,
+            &DateFormatChangedBroadcaster::dateFormatChanged,
+            this,
+            &BaseTrackTableModel::slotEmitDataChangedForDateColumns);
 }
 
 void BaseTrackTableModel::initTableColumnsAndHeaderProperties(

src/library/basetracktablemodel.h

@@ -280,6 +280,10 @@ class BaseTrackTableModel : public QAbstractTableModel, public TrackModel {
             const CoverInfo& coverInfo,
             const QPixmap& pixmap);
 
+    /// Called via signal from DateFormatChangedBroadcaster,
+    /// will tell the view(s) to repaint date columns when visible
+    void slotEmitDataChangedForDateColumns();
+
   private:
     QVariant rawSiblingValue(
             const QModelIndex& index,

src/library/dateformatbroadcaster.cpp

@@ -0,0 +1,6 @@
+#include "library/dateformatbroadcaster.h"
+
+#include "moc_dateformatbroadcaster.cpp"
+
+DateFormatChangedBroadcaster::DateFormatChangedBroadcaster() {
+}

src/library/dateformatbroadcaster.h

@@ -0,0 +1,19 @@
+#pragma once
+
+#include <QObject>
+
+#include "util/singleton.h"
+
+class DateFormatChangedBroadcaster
+        : public QObject,
+          public Singleton<DateFormatChangedBroadcaster> {
+    Q_OBJECT
+  public:
+  signals:
+    void dateFormatChanged();
+
+  protected:
+    DateFormatChangedBroadcaster();
+    ~DateFormatChangedBroadcaster() override = default;
+    friend class Singleton<DateFormatChangedBroadcaster>;
+};

src/library/library.cpp

@@ -10,6 +10,7 @@
 #include "library/autodj/autodjfeature.h"
 #include "library/banshee/bansheefeature.h"
 #include "library/browse/browsefeature.h"
+#include "library/dateformatbroadcaster.h"
 #ifdef __ENGINEPRIME__
 #include "library/export/libraryexporter.h"
 #endif
@@ -76,6 +77,8 @@ Library::Library(
                   mixxx::library::prefs::kKeyNotationConfigKey)) {
     qRegisterMetaType<LibraryRemovalType>("LibraryRemovalType");
 
+    DateFormatChangedBroadcaster::createInstance();
+
     connect(m_pTrackCollectionManager,
             &TrackCollectionManager::libraryScanFinished,
             this,
@@ -269,7 +272,9 @@ Library::Library(
             kEditMetadataSelectedClickDefault);
 }
 
-Library::~Library() = default;
+Library::~Library() {
+    DateFormatChangedBroadcaster::destroy();
+}
 
 TrackCollectionManager* Library::trackCollectionManager() const {
     // Cannot be implemented inline due to forward declarations

src/test/librarytest.cpp

@@ -35,10 +35,12 @@ LibraryTest::LibraryTest()
           m_pTrackCollectionManager(newTrackCollectionManager(config(), dbConnectionPooler())),
           m_keyNotationCO(mixxx::library::prefs::kKeyNotationConfigKey) {
     CoverArtCache::createInstance();
+    DateFormatChangedBroadcaster::createInstance();
 }
 
 LibraryTest::~LibraryTest() {
     CoverArtCache::destroy();
+    DateFormatChangedBroadcaster::destroy();
 }
 
 TrackPointer LibraryTest::getOrAddTrackByLocation(