Skip to content

Commit 64ef6ef

Browse files
Apply suggestions from code review
Co-authored-by: Daniel Schürmann <daschuer@mixxx.org>
1 parent ed68fc9 commit 64ef6ef

2 files changed

Lines changed: 1 addition & 9 deletions

File tree

src/engine/sync/abletonlink.cpp

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -53,14 +53,6 @@ AbletonLink::~AbletonLink() {
5353
m_pLink->setNumPeersCallback([](std::size_t) {});
5454
m_pLink->enable(false);
5555

56-
// Disconnect the connection from the Link GUI button
57-
if (m_pLinkButton) {
58-
QObject::disconnect(m_pLinkButton.get(),
59-
&ControlObject::valueChanged,
60-
this,
61-
&AbletonLink::slotControlSyncEnabled);
62-
}
63-
6456
// Destroy control objects before releasing Link.
6557
m_pNumLinkPeers.reset();
6658
m_pLinkButton.reset();

src/engine/sync/abletonlink.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ class AbletonLink : public QObject, public Syncable {
103103
private:
104104
ableton::link::HostTimeFilter<MixxxClockRef> m_hostTimeFilter;
105105
QString m_group;
106-
EngineSync* m_pEngineSync; // unowned, must outlive this.
106+
EngineSync* m_pEngineSync; // borrowed, must outlive this.
107107
SyncMode m_syncMode;
108108

109109
mixxx::Bpm m_oldTempo;

0 commit comments

Comments
 (0)