fix(LateNightQML): correct deck display and waveform markers

Author: xARSENICx

res/skins/LateNightQML/Deck/LateNightBpmTapEditor.qml

@@ -12,7 +12,6 @@ Item {
     property string mode: "listen"
     property real originalEditValue: 0
     property bool editingBpm: true
-    property real tapModeEnteredAt: 0
 
     readonly property bool listenHovered: listenArea.containsMouse
     readonly property int hoverLeaveTimeout: 2000
@@ -33,7 +32,7 @@ Item {
         } else if (newMode === "edit") {
             startEditMode();
         } else if (newMode === "tap") {
-            root.tapModeEnteredAt = Date.now();
+            tapClickGuardTimer.restart();
             hideTimer.stop();
         } else if (newMode === "listen") {
             editInput.text = "";
@@ -42,7 +41,7 @@ Item {
     }
 
     function handleTapClick(mouse) {
-        if (Date.now() - root.tapModeEnteredAt < root.tapModeClickGuardTimeout) {
+        if (tapClickGuardTimer.running) {
             return;
         }
         root.tapControl(mouse.button === Qt.RightButton ? bpmTapProxy : tempoTapProxy);
@@ -154,6 +153,12 @@ Item {
         onTriggered: root.switchMode("listen")
     }
 
+    Timer {
+        id: tapClickGuardTimer
+        interval: root.tapModeClickGuardTimeout
+        repeat: false
+    }
+
     MouseArea {
         id: listenArea
         anchors.fill: parent

res/skins/LateNightQML/Deck/RatePlaceholder.qml

@@ -48,12 +48,6 @@ Item {
         key: "bpm"
     }
 
-    Mixxx.ControlProxy {
-        id: visualBpmProxy
-        group: root.group
-        key: "visual_bpm"
-    }
-
     Mixxx.ControlProxy {
         id: rateRatioProxy
         group: root.group
@@ -142,7 +136,7 @@ Item {
                 Text {
                     width: parent.width
                     height: 24
-                    text: visualBpmProxy.value.toFixed(2)
+                    text: bpmProxy.value.toFixed(2)
                     font.family: "Open Sans"
                     font.pixelSize: 20
                     font.bold: true

src/qml/qmllibraryproxy.h

@@ -1,6 +1,5 @@
 #pragma once
 #include <QObject>
-#include <QPoint>
 #include <QQmlEngine>
 #include <QString>
 #include <Qt>

src/qml/qmlwaveformrenderer.cpp

@@ -440,8 +440,8 @@ QmlWaveformRendererFactory::Renderer QmlWaveformRendererMark::create(
                         pMark->align(),
                         pMark->text(),
                         pixmap,
-                        icon,
                         endPixmap,
+                        icon,
                         endIcon,
                         pMark->color(),
                         pMark->enabledOpacity(),