Add control for playback marker horizontal position

Implements control for adjusting the horizontal position of the playback marker/line over waveforms.

- Adds [Waveform],PlayMarkerPosition control (0.0 = left, 1.0 = right)
- Creates ControlPotmeter for smooth value adjustment
- Exposes control in controller picker menu for MIDI/HID mapping
- Adds tooltip for the control
- Preserves existing playback marker position functionality

Fixes #14288

Author: Milkii Brewster

src/controllers/controlpickermenu.cpp

@@ -1563,6 +1563,11 @@ ControlPickerMenu::ControlPickerMenu(QWidget* pParent)
             tr("Reset the waveform zoom level to the default value selected in "
                "Preferences -> Waveforms"),
             pGuiMenu);
+    addControl("[Waveform]",
+            "play_marker_position",
+            tr("Playback Marker Position"),
+            tr("Adjust the position of the playback marker on the waveforms"),
+            pGuiMenu);
 
     pGuiMenu->addSeparator();
 

src/skin/legacy/tooltips.cpp

@@ -73,6 +73,10 @@ void Tooltips::addStandardTooltips() {
             << tr("Waveform Zoom")
             << QString("%1").arg(resetToDefault);
 
+    add("[Waveform],play_marker_position")
+            << tr("Playback Marker Position")
+            << tr("Adjust the position of the playback marker on the waveforms.");
+
     add("spinny")
             << tr("Spinning Vinyl")
             << tr("Rotates during playback and shows the position of a track.")

src/waveform/waveformwidgetfactory.cpp

@@ -1,5 +1,6 @@
 #include "waveform/waveformwidgetfactory.h"
 
+#include "control/controlpotmeter.h"
 #include "waveform/renderers/waveformrendererabstract.h"
 #include "waveform/waveform.h"
 
@@ -436,6 +437,21 @@ bool WaveformWidgetFactory::setConfig(UserSettingsPointer config) {
                     WaveformWidgetRenderer::s_defaultPlayMarkerPosition);
     setPlayMarkerPosition(m_playMarkerPosition);
 
+    // Create control for playback marker position (0.0 = left, 1.0 = right)
+    if (!m_pPlayMarkerPositionCO) {
+        m_pPlayMarkerPositionCO = std::make_unique<ControlPotmeter>(
+                ConfigKey(kWaveformGroup, QStringLiteral("play_marker_position")),
+                0.0,
+                1.0);
+        connect(m_pPlayMarkerPositionCO.get(),
+                &ControlObject::valueChanged,
+                this,
+                [this](double value) {
+                    setPlayMarkerPosition(value);
+                });
+    }
+    m_pPlayMarkerPositionCO->set(m_playMarkerPosition);
+
     int untilMarkShowBeats =
             m_config->getValueString(
                             ConfigKey(kWaveformGroup, QStringLiteral("UntilMarkShowBeats")))
@@ -794,6 +810,9 @@ void WaveformWidgetFactory::setPlayMarkerPosition(double position) {
         m_config->setValue(ConfigKey(kWaveformGroup, QStringLiteral("PlayMarkerPosition")),
                 m_playMarkerPosition);
     }
+    if (m_pPlayMarkerPositionCO) {
+        m_pPlayMarkerPositionCO->set(m_playMarkerPosition);
+    }
 
     for (const auto& holder : std::as_const(m_waveformWidgetHolders)) {
         holder.m_waveformWidget->setPlayMarkerPosition(m_playMarkerPosition);

src/waveform/waveformwidgetfactory.h

@@ -3,6 +3,7 @@
 #include <QObject>
 #include <QSurfaceFormat>
 #include <QVector>
+#include <memory>
 #include <vector>
 
 #include "preferences/usersettings.h"
@@ -20,6 +21,7 @@ class WWaveformViewer;
 class WaveformWidgetAbstract;
 class VSyncThread;
 class GuiTick;
+class ControlPotmeter;
 class VisualsManager;
 
 class WaveformWidgetAbstractHandle {
@@ -368,4 +370,5 @@ class WaveformWidgetFactory : public QObject,
     double m_actualFrameRate;
     int m_vSyncType;
     double m_playMarkerPosition;
+    std::unique_ptr<ControlPotmeter> m_pPlayMarkerPositionCO;
 };