fix(LateNightQML): bridge legacy library search and shortcut safety

Author: xARSENICx

res/skins/LateNight/style_classic.qss

@@ -2603,7 +2603,8 @@ WSearchLineEdit {
   selection-color: #000;
   selection-background-color: #ccc;
   }
-  WSearchLineEdit:focus {
+  WSearchLineEdit:focus,
+  WSearchLineEdit[qmlBridgeFocused="true"] {
     padding: 1px;
     border: 2px solid #d08e00;
     border-radius: 0px;

res/skins/LateNight/style_palemoon.qss

@@ -3268,7 +3268,8 @@ WSearchLineEdit {
   selection-color: #000;
   selection-background-color: #ccc;
   }
-  WSearchLineEdit:focus {
+  WSearchLineEdit:focus,
+  WSearchLineEdit[qmlBridgeFocused="true"] {
     padding: 1px;
     border: 2px solid #257b82;
     border-radius: 0px;

res/skins/LateNightQML/Library.qml

@@ -4,7 +4,13 @@ import QtQuick
 Item {
     id: root
 
+    function focusSearch() {
+        legacyLibrary.focusSearch();
+    }
+
     Mixxx.LegacyLibraryItem {
+        id: legacyLibrary
+
         anchors.fill: parent
     }
 }

src/controllers/keyboard/keyboardeventfilter.h

@@ -4,6 +4,7 @@
 #include <QLocale>
 #include <QMultiHash>
 #include <QObject>
+#include <QPointer>
 
 #include "control/controlobject.h"
 #include "preferences/configobject.h"
@@ -122,7 +123,7 @@ class KeyboardEventFilter : public QObject {
     // Widgets that have mappable connections, registered by LegacySkinParser
     // during skin construction.
     QList<WBaseWidget*> m_widgets;
-    WSearchLineEdit* m_pSearchBar;
+    QPointer<WSearchLineEdit> m_pSearchBar;
 
     // Multi-hash of key sequence to
     QMultiHash<ConfigValueKbd, ConfigKey> m_keySequenceToControlHash;

src/qml/qmllegacylibraryitem.cpp

@@ -34,6 +34,7 @@
 
 #include "control/controlproxy.h"
 #include "control/controlpushbutton.h"
+#include "controllers/keyboard/keyboardeventfilter.h"
 #include "library/library.h"
 #include "library/library_prefs.h"
 #include "mixer/playermanager.h"
@@ -88,6 +89,15 @@ SchemeStyle getActiveSchemeStyle() {
 
 QmlLegacyLibraryItem::~QmlLegacyLibraryItem() = default;
 
+void QmlLegacyLibraryItem::focusSearch() {
+    VERIFY_OR_DEBUG_ASSERT(m_pSearchLineEdit) {
+        return;
+    }
+    forceActiveFocus(Qt::ShortcutFocusReason);
+    updateEmbeddedFocus(m_pSearchLineEdit, Qt::ShortcutFocusReason);
+    requestRender();
+}
+
 QmlLegacyLibraryItem::QmlLegacyLibraryItem(QQuickItem* pParent)
         : QQuickPaintedItem(pParent),
           m_pRootWidget(std::make_unique<QWidget>()) {
@@ -191,10 +201,15 @@ QmlLegacyLibraryItem::QmlLegacyLibraryItem(QQuickItem* pParent)
     VERIFY_OR_DEBUG_ASSERT(pLibrary) {
         return;
     }
+    KeyboardEventFilter* pKeyboard = QmlLibraryProxy::getKeyboard();
+    VERIFY_OR_DEBUG_ASSERT(pKeyboard) {
+        return;
+    }
 
+    pKeyboard->registerSearchBar(m_pSearchLineEdit);
     pLibrary->bindSearchboxWidget(m_pSearchLineEdit);
     pLibrary->bindSidebarWidget(m_pSidebar);
-    pLibrary->bindLibraryWidget(m_pLibraryWidget, QmlLibraryProxy::getKeyboard());
+    pLibrary->bindLibraryWidget(m_pLibraryWidget, pKeyboard);
 
     // The legacy skin parser makes this connection in parseLibrary().
     // Without it the search signal never reaches WLibrary and the
@@ -1412,6 +1427,16 @@ void QmlLegacyLibraryItem::updateEmbeddedFocus(
         pFocusTarget = pFocusTarget->parentWidget();
     }
 
+    if (m_pSearchLineEdit) {
+        const bool searchFocused = pFocusTarget == m_pSearchLineEdit;
+        if (m_pSearchLineEdit->property("qmlBridgeFocused").toBool() != searchFocused) {
+            m_pSearchLineEdit->setProperty("qmlBridgeFocused", searchFocused);
+            m_pSearchLineEdit->style()->unpolish(m_pSearchLineEdit);
+            m_pSearchLineEdit->style()->polish(m_pSearchLineEdit);
+            m_pSearchLineEdit->update();
+        }
+    }
+
     if (pFocusTarget == m_pFocusedWidget) {
         return;
     }

src/qml/qmllegacylibraryitem.h

@@ -29,6 +29,7 @@ class QmlLegacyLibraryItem : public QQuickPaintedItem {
     ~QmlLegacyLibraryItem() override;
 
     void paint(QPainter* pPainter) override;
+    Q_INVOKABLE void focusSearch();
 
   protected:
     void mousePressEvent(QMouseEvent* pEvent) override;