Unicode DeviceSQL strings in PDB are UTF-16-BE, not UTF-16-LE

[0xsuk]

Bug Description

Mixxx uses kaitai struct to extract data from rekordbox pdb files.
rekordbox data binary was reversed by another project called crate-digger.
Mixxx uses an old copy of crate-pdb.ksy file for parsing pdb files, which needs to be updated.

Deep-Symmetry/crate-digger#14

As shown in the image, Japanese characters are not properly displayed.

Version

No response

OS

No response

[Swiftb0y]

I think the title of that pull request you mentioned is backwards, it's actually utf16-le and was just previously assumed to be utf16-be. But you're right, the ksy definitions are outdated.

[Swiftb0y]

Thanks for digging through the issue, notifying us and testing the fix. It will be part of the next mixxx release.

[dimashenme]

is the fix available in a branch that I can compile locally while waiting for the next release to come out?

[ronso0]

#13293 has been merged on June 9th so the fix will be in Mixxx 2.4.2

You can build the 2.4 branch (stable), or 2.5 (currently beta).