Traktor Kontrol S4: add option to disable tempo fader

[SamWhited]

Feature Description

In the manual for the Traktor Kontrol S4 it says that pressing shift and hitting sync lock will lock the tempo fader so that it no longer has any effect. I assume they mean "in Traktor" because it doesn't seem to be a feature of the controller. It would be nice if the Mixxx plugin supported this functionality.

[ronso0]

Could you please point us to the section you refer to?
I can't find a mention of such a lock feature https://manual.mixxx.org/2.5/en/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3

[SamWhited]

In the controller manual distributed by Native Instruments with the controller, not the Mixxx manual, sorry. I'm assuming this is something the Traktor software does and not the controller itself since it doesn't seem to work. Seems like a useful feature that could be duplicated.

[ronso0]

Ah, okay.
Shift + Sync is already toggling Sync Leader, so that mapping can't really be used I think.

Do you think you'll want to disable/enable the tempo fader spontaneously or would a mapping option suffice?

[SamWhited]

A mapping option would probably be fine by me (I have a slightly broken tempo fader on one deck that likes to skip around while it's actually sitting still, making the music go wonky, cleaning has had little effect and you can't get a new one for love or money, apparently).

[ronso0]

I think an option (for everyone) maybe too much, there are laready so many options for this device.
And (if I'm not mistaking) this would be the first mapping that allows to switch off the tempo fader.
@acolombier wdyt?

Anyway, @SamWhited you can simply disable processing of tempoFader(), or comment out the assignment here and here

[SamWhited]

I've already commented it out, FWIW I submitted this upstream because this is a feature in Traktor for this controller (you hit shift + lock), so it seems worth replicating. Even if yours isn't broken, they're easy to bump.