Update WiX toolset to 6.0.2 by JoergAtGithub · Pull Request #15060 · mixxxdj/mixxx

JoergAtGithub · 2025-06-30T21:13:01Z

Ensures for ARM64 from the begining that we generate valid installations.
This hopefully will reduce the number of failed installation attemps, because the need for Admin rights is now correctly visualized and users see that they need elevated rights to install it.
Installer is generally smaller and faster.

…t 6.0.1 Use the same WiX toolset installation on both Windows architectures Fix the broken Multiuser Installation of the WiX 3.14 support in CPack

daschuer · 2025-09-29T21:52:14Z

          # This is a workaround for a SSL false positive in cmake 3.26.4
          # When downloading the manual. 3.21 is required for installing the
          # ANGLE Dlls via IMPORTED_RUNTIME_ARTIFACTS


The comment is from here:
#12197
Can you verify that downloading the manual works with CMake 3.30

Suggested change

# This is a workaround for a SSL false positive in cmake 3.26.4

# When downloading the manual. 3.21 is required for installing the

# ANGLE Dlls via IMPORTED_RUNTIME_ARTIFACTS

# On Windows, we need at least CMake 3.30.x for WIX toolset >= 4.0

I tried this PR with my local CMake 4.1.1 which comes with VS2026 and it downloads the manual flawless:

[CMake] -- Downloading manual from https://downloads.mixxx.org/manual/2.6/mixxx-manual-2.6-en.pdf... 1> [CMake] -- [download 0% complete] 1> [CMake] -- [download 1% complete] 1> [CMake] -- [download 2% complete]

daschuer · 2026-02-25T20:37:54Z

For my understanding the C# code of wixsharp is only an interface that finally creates a wix code and than to an msi file. If it is possible with wixsharp, with some luck it is also possible for wix.

…LL, that can be called inside of our MSI installer. FindAllRelatedMixxxInstallations detects old Mixxx installation with the illegal install scope "none"

JoergAtGithub · 2026-03-09T06:47:40Z

I think I fixed this. The C# code section pointed by @daschuer does not generate MSI code, it is code that is called by MSI as Custom Action. I implemented this functionality as C++ DLL which is called as Custom Action in the MSI to get all previous Mixxx installations.

The standad Windows API FindRelatedProducts returns only Installations where UpgradeCode and installation scope matches
The custom FindAllRelatedMixxxInstallations returns all Installations where the UpgradeCode matches, regardless of the installation scope

This solves the issue with the old installations, where CPack set the invalid installation scope none.

daschuer

Great you have found a solution. I have added some nit picks for code style, basically.
How it the DLL deployed? Does Wix care for it automatically? Maybe you can drop a comment about it.

JoergAtGithub · 2026-03-09T07:54:06Z

How it the DLL deployed? Does Wix care for it automatically? Maybe you can drop a comment about it.

Yes, it should deploy it automatically. But it would be good, if someone with a vanilla system could confirm that this works.
I assume that we will need to sign this DLL with our certificate.

daschuer · 2026-03-09T08:12:58Z

Signing can't hurd. If it is only part of the signed MSI it is probably already no security risk.

acolombier · 2026-03-09T23:39:58Z

Tested again:

Installed 2.5.5 (Candidate)

Installed 2.6.0 (Beta)

Works like a charm! Note that I could see a Collecting for migration info for a split second in the 2.6 install wizard, but nothing more disruptive than that.

acolombier · 2026-03-09T23:41:34Z

+    // Enumerate ALL products with our UpgradeCode (scope-agnostic).
+    wchar_t relatedProduct[kMsiGuidBufferSize] = {};
+    DWORD index = 0;
+    while (MsiEnumRelatedProductsW(kMixxxUpgradeCode, 0, index, relatedProduct) == ERROR_SUCCESS) {


ERROR_SUCCESS 😆

daschuer · 2026-03-10T07:07:03Z

I have tested on a Windows 10 VM and got this error after installing on top of a 2.7 alpha install:

Really strange the start menu entry points to:
C:\Users\dasch\Downloads\sign\mixxx.exe
A folder I have created for testing purpose a time ago.

The Mixxx.exe in the Program folder was missing, the other files are there.

A "Repair" install repairs the installation. I have no clue what Microsoft is doing :-/

daschuer · 2026-03-10T07:19:06Z

When downgrading to 2.5 from this 2.6 the user create a program folder of partially new and old files.
This happens if a user downgrades form the new 2.6 to 2.5.

We need to advice the users that they uninstall 2.6 manually Before installing downgrading 2.5. With the old installer, the user was not able to downgrade and was prompted to uninstall the newer version manually.
This is prompt is missing now.

Can we patch the installer for 2.5.5 based on Old Wix in the same way that a new 2.6 is found, that they can smoothy change between 2.5.5 and 2.6.0 at least?

For the already released 2.5.4 we can do nothing?
Is this even worse the extra work?

What do you think?

daschuer · 2026-03-10T08:10:31Z

ChatGPT has this explanation:

Why MSI might find the EXE in your Downloads folder

MSI internally tracks component keypaths and source locations.

If the component identity got mixed up during upgrade:

Old product instance still registered

Component GUID reused

KeyPath resolution runs

Windows searches known source locations

It finds mixxx.exe somewhere else (like your test folder)

Then the advertised shortcut resolves to that.

This looks insane, but it's classic MSI behavior.

daschuer

The code looks good. I read a bit and while the finding with the random mixxx.exe is a severe issue. It is unlikely caused by you changes.

The question remains: do we want to add a similar patch to the 2.5 branch detecting the new installation?

JoergAtGithub · 2026-03-13T20:04:46Z

The code looks good. I read a bit and while the finding with the random mixxx.exe is a severe issue. It is unlikely caused by you changes.

The question remains: do we want to add a similar patch to the 2.5 branch detecting the new installation?

I don't think we should delay 2.5.5 for this, as we discontinue support for former releases anyway. But I would mention in the 2.6 changelog, that downgrade requires manual deinstallation before installing the former release.

daschuer

LGTM, thank you.

Update the long time deprecated WiX toolset 3.14 to latest WiX toolse…

5c47029

…t 6.0.1 Use the same WiX toolset installation on both Windows architectures Fix the broken Multiuser Installation of the WiX 3.14 support in CPack

JoergAtGithub added the changelog This PR should be included in the changelog label Jun 30, 2025

github-actions Bot added the build label Jun 30, 2025

ronso0 added the windows label Jun 30, 2025

daschuer reviewed Jul 1, 2025

View reviewed changes

Comment thread .github/workflows/build.yml Outdated

Comment thread .github/workflows/build.yml Outdated

Comment thread CMakeLists.txt

JoergAtGithub added this to the 2.6.0 milestone Aug 17, 2025

daschuer reviewed Sep 29, 2025

View reviewed changes

JoergAtGithub force-pushed the Update_WiX_toolset branch from d0cb83f to 9ad7d92 Compare December 1, 2025 19:30

Merge remote-tracking branch 'upstream/2.6' into Update_WiX_toolkit

31a41a1

JoergAtGithub force-pushed the Update_WiX_toolset branch from 9ad7d92 to 31a41a1 Compare December 1, 2025 19:34

JoergAtGithub removed controller mappings skins labels Dec 1, 2025

github-actions Bot added the packaging label Mar 8, 2026

JoergAtGithub force-pushed the Update_WiX_toolset branch 2 times, most recently from ae2a3b6 to dc85eaa Compare March 8, 2026 23:23

Implemented a custom action FindAllRelatedMixxxInstallations as new D…

f9b07d7

…LL, that can be called inside of our MSI installer. FindAllRelatedMixxxInstallations detects old Mixxx installation with the illegal install scope "none"

JoergAtGithub force-pushed the Update_WiX_toolset branch from dc85eaa to f9b07d7 Compare March 8, 2026 23:34

JoergAtGithub requested a review from daschuer March 9, 2026 06:47

JoergAtGithub added the needs testing label Mar 9, 2026

daschuer requested changes Mar 9, 2026

View reviewed changes

Comment thread packaging/wix/CMakeLists.txt Outdated

Comment thread packaging/wix/mixxxupgradecustomaction.cpp Outdated

Comment thread packaging/wix/mixxxupgradecustomaction.cpp Outdated

Comment thread CMakeLists.txt

Renamed cpp and dll to all lower case

f90ca30

JoergAtGithub force-pushed the Update_WiX_toolset branch from 89a5a76 to 94499b8 Compare March 9, 2026 21:17

Use const expression and explain their values in comments

1a16de9

JoergAtGithub force-pushed the Update_WiX_toolset branch from 94499b8 to 1a16de9 Compare March 9, 2026 22:33

Code-sign mixxxupgradecustomaction.dll

2c651af

acolombier reviewed Mar 9, 2026

View reviewed changes

Use latest WiX release 6.0.2

da85c24

JoergAtGithub changed the title ~~Update WiX toolset to 6.0.1~~ Update WiX toolset to 6.0.2 Mar 10, 2026

JoergAtGithub requested a review from daschuer March 10, 2026 19:26

daschuer approved these changes Mar 11, 2026

View reviewed changes

daschuer approved these changes Mar 13, 2026

View reviewed changes

daschuer merged commit c2cc310 into mixxxdj:2.6 Mar 13, 2026
24 of 46 checks passed

JoergAtGithub deleted the Update_WiX_toolset branch March 13, 2026 23:11

Uh oh!

Uh oh!

Conversation

JoergAtGithub commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

daschuer Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

JoergAtGithub Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

daschuer commented Feb 25, 2026

Uh oh!

JoergAtGithub commented Mar 9, 2026

Uh oh!

daschuer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JoergAtGithub commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daschuer commented Mar 9, 2026

Uh oh!

acolombier commented Mar 9, 2026

Uh oh!

acolombier Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

daschuer commented Mar 10, 2026

Uh oh!

daschuer commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daschuer commented Mar 10, 2026

Uh oh!

daschuer left a comment

Choose a reason for hiding this comment

Uh oh!

JoergAtGithub commented Mar 13, 2026

Uh oh!

daschuer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

JoergAtGithub commented Jun 30, 2025 •

edited

Loading

JoergAtGithub commented Mar 9, 2026 •

edited

Loading

daschuer commented Mar 10, 2026 •

edited

Loading