DDJ-FLX4: Map shift+cue to start_stop

[alajovic]

Implements the suggestion given in #15998.

[alajovic]

@acolombier Care to review this? (Picking you because you were the first responder to my #15998 and nobody else seems to be volunteering.) It's a trivial change, I also tested it on a DDJ-FLX4 controller and it works as expected.

[acolombier]

@schmic and @Robert904 you have recently contributed to this mapping, what are your thoughts about this change as default?
@alajovic note that an option could be to the use the controller setting and make this change an alternative mapping instead

[schmic]

@acolombier that change would make me use that mapping, +1 to make this the default

[Robert904]

@acolombier I personally find that change interesting, it indeed seems better than the current behavior that was simply inherited from the DDJ-400 mapping.

That being said, I actually don't use the console myself for DJing, I don't know if there is some standard or expectation for how this CUE button is mapped, and I don't find information in the vendor's documentation for how the supported commercial softwares would use the shift-CUE.

So, +1 as well from my point of view!

[acolombier]

Great, thank you both for your quick feedback! @alajovic can you confirm there is no need to update the manual before I press "merge"?

[alajovic]

This key combo was not documented at all in the manual - even before my change. I wanted to add it but was stopped a bit by the problem described in mixxxdj/manual#823 (commented about it here). But yes, my plan is to describe this. I can force skipping the hyperlink check and push the change if that's an acceptable workaround at the moment.

[acolombier]

I have merged the manual workaround now - this false positive has indeed been a pain lately so this should hopefully help you getting the manual update out painlessly