Overview cue upate regression after #15968

[ronso0]

Bug Description

filing this in addition to my comment in the PR so we have a blocker bug

Unfortunately #15968 introduces some update regressions in the overview.
Hotcues:

• set hotcue1 -> no update in overview
• set hotcue2 -> hotcue1 pops up in overview

Loop cues:

• updated/shown after seek in the overview (repaint?)

Same delay after clearing hotcues: they're removed only after forced repaint (hover overview)

mixxx-overview-hotcues-delayed-update.webm

Version

No response

OS

No response

[daschuer]

I cannot confirm the issue shown in the video with the current 2.6 branch.

The relevant change was to remove the connection to the waveform change marks:

    m_marks.connectSamplePositionChanged(this, &WOverview::onMarkChanged);
    m_marks.connectSampleEndPositionChanged(this, &WOverview::onMarkChanged);

because we can rely on

        connect(pNewTrack.get(), &Track::cuesUpdated, this, &WOverview::receiveCuesUpdated);

In your case this slot is probably called, before the cues are updated ??
strange.

Does restoring the removed lines fix the issue for you? The main waveform works with the same slot. Does it updated properly?

Interesting is also that the Hotcue 3 label moves to the main cue after clearing the cues in you screen cast. Strange.

[ronso0]

Scrolling waveforms are fine.

In your case this slot is probably called, before the cues are updated ??

Apparently. The slot in WOverview is called but nothing changes in the view.

Sure I can try to revert these commits. Will report back. (but then the issue this was supposed to fix is back)

[daschuer]

I can confirm the issue using main. So there must be a distance merge conflict or something.
Can you confirm that there is no issue when you build plain 2.6?

[ronso0]

I seeing this with pure 2.6 -- just fetched again and rebuilt: issue persists

[ywwg]

are you on wayland or X?

[ronso0]

I'm using X

[ronso0]

Fixed by reverting the breaking commits in #16088