Vinyl control scope update is wasting CPU

[daschuer]

Bug Description

We have a vinyl scope (Quality Report) update rate of 15 Hz. However the vinyl control processor generates the report at its maximum update rate.

A timer flushes the signal quality reports in a while loop to the listeners which can be up to 256 at once, even though only the last one is visible. This creates the situation that we are "blind" in between. Is this an issue?

Instead of using a timer putting a signal on the QT queue the processor should do it:

mixxx/src/vinylcontrol/vinylcontrolprocessor.cpp

Line 113 in e3e2f63

if (pProcessor && m_bReportSignalQuality) {

Version

No response

OS

No response

[ronso0]

Oh, could that be the reason for the temporary logspam I see (occassionally) when I enable passthrough?
#14236

There are only max 4 listeners thoughg, no?

mixxx/src/vinylcontrol/defs_vinylcontrol.h

Line 78 in e3e2f63

#define MIXXX_VINYL_SCOPE_UPDATE_LATENCY_MS 66

[daschuer]

Not the cause, but related. After the change it will be less spammy.

[ronso0]

Ah, got it, PR is here #16538