Feature/bug?: working better with nested lists

[IndianBoy42]

local blah = {
  { 2, 1, 6 },
  { 3, 4, 6 },
  { 3, 4, 6 },
}

If i have nested lists like this, I don't think there is anywhere to place the cursor that would make ISwapWith work with the outer list. In fact, placing the cursor on the braces of one of the inner lists makes iswap think we're trying to work on the inner list (because technically the cursor is contained within the inner list.

Even if this is fixed to work I think the nicer solution is to allow ISwapWith from visual mode and then ISwapWith will try its best to treat the visual range as the cur_node. Basically ignore lists that are contained within the visual range, or if the visual range covers multiple children of a list then we shouldn't operate within that list.

I've actually already started the implementation for a PR but I wanted to post this for discussion and if you agree with the solution?

[mizlan]

visual mode support as you describe is always something i’ve wanted to add!

…

On Thu, Jun 1, 2023 at 6:39 AM Anshuman Medhi ***@***.***> wrote: local blah = { { 2, 1, 6 }, { 3, 4, 6 }, { 3, 4, 6 }, } If i have nested lists like this, I don't think there is anywhere to place the cursor that would make ISwapWith work with the outer list. In fact, placing the cursor on the braces of one of the inner lists makes iswap think we're trying to work on the inner list (because technically the cursor is contained within the inner list. Even if this is fixed to work I think the nicer solution is to allow ISwapWith from visual mode and then ISwapWith will try its best to treat the visual range as the cur_node. Basically ignore lists that are contained within the visual range, or if the visual range covers multiple children of a list then we shouldn't operate within that list. I've actually already started the implementation for a PR but I wanted to post this for discussion and if you agree with the solution? — Reply to this email directly, view it on GitHub <#79>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKSBU2P4G6NH4H3NUMVKRF3XJCLR3ANCNFSM6AAAAAAYW6HTNI> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[IndianBoy42]

Just for posteritys sake another solution I thought of is that after starting iswap, if the user finds they're at the wrong level of nesting, they could hit some special key (not in the labels list) to select the next level up and replace all the labels

I think both are useful, depending on if the user correctly intuits which level of nesting they're at.

We could even, if there are spare labels, label multiple levels of list nodes, the user just has to take care not to hit labels from different nesting levels (or maybe do that if they want to and the nodes don't overlap)

[mizlan]

I like the special key idea, the multiple levels seems to error-prone with the edge cases I can foresee. Because we must also highlight ranges that must somehow be distinguished. since a singular label might not always single out a single element.

[IndianBoy42]

Oh yeah, highlighting overlapping ranges is pretty annoying. Same problem in nvim-treehopper where it's inherent to the functionality (selecting ranges) Get Outlook for Android<https://aka.ms/AAb9ysg>

…

________________________________ From: Michael Lan ***@***.***> Sent: Monday, June 5, 2023 2:38:10 PM To: mizlan/iswap.nvim ***@***.***> Cc: Anshuman MEDHI ***@***.***>; Author ***@***.***> Subject: Re: [mizlan/iswap.nvim] Feature/bug?: working better with nested lists (Issue #79) I like the special key idea, the multiple levels seems to error-prone with the edge cases I can foresee. Because we must also highlight ranges that must somehow be distinguished. since a singular label might not always single out a single element. — Reply to this email directly, view it on GitHub<#79 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABNUNQNUFUZMVH2LXJJEB4TXJV5FFANCNFSM6AAAAAAYW6HTNI>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[IndianBoy42]

i'm trying to implement the expand_key idea, since its a bit easier than the visual mode idea. ISwap and ISwapWith are pretty easy (abusing goto lol). ISwapNode already lets you select arbitrary nesting, but I'm trying to understand the ISwapNodeWith search logic and I'm not really sure about the goal of how you want to choose outer_cursor_node