Skip to content

Commit 7eb60bb

Browse files
authored
Stability: replace Array with std::vector for now (#140)
1 parent b6b0e5d commit 7eb60bb

4 files changed

Lines changed: 12 additions & 11 deletions

File tree

src/opti-lib/src/JsonReader.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ const rapidjson::Value & JsonValueWrapper::GetValueJson(const EnjoLib::Str & nam
6767
return m_obj[name.c_str()];
6868
}
6969

70-
EnjoLib::Array<BatteryParams> JsonReader::ReadBatteries(bool verbose) const
70+
std::vector<BatteryParams> JsonReader::ReadBatteries(bool verbose) const
7171
{
7272
const CharManipulations cman;
7373
std::vector<BatteryParams> ret;
@@ -116,7 +116,7 @@ EnjoLib::Array<BatteryParams> JsonReader::ReadBatteries(bool verbose) const
116116
return ret;
117117
}
118118

119-
EnjoLib::Array<Computer> JsonReader::ReadComputers(bool verbose) const
119+
std::vector<Computer> JsonReader::ReadComputers(bool verbose) const
120120
{
121121
const CharManipulations cman;
122122
std::vector<Computer> ret;
@@ -183,7 +183,7 @@ EnjoLib::Array<Computer> JsonReader::ReadComputers(bool verbose) const
183183
return ret;
184184
}
185185

186-
EnjoLib::Array<Habit> JsonReader::ReadHabits(bool verbose) const
186+
std::vector<Habit> JsonReader::ReadHabits(bool verbose) const
187187
{
188188
const CharManipulations cman;
189189
std::vector<Habit> ret;
@@ -271,7 +271,7 @@ ConfigSol JsonReader::ReadConfigSol(bool verbose) const
271271
rapidjson::Document d;
272272
parseJsonOrThrow(jsonFile, m_verbose, d);
273273
JsonValueWrapper jwrap(d, idd);
274-
274+
275275
/// TODO: This should be secured better, like the rest, but it's multilayered.
276276
ret.m_outDir = d["paths"]["DIR_TMP"].GetString();
277277
return ret;

src/opti-lib/src/JsonReader.h

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88

99
#include <Util/StrFwd.hpp>
1010
#include <Template/Array.hpp>
11+
#include <STD/Vector.hpp>
1112

1213
class ConfigSol;
1314

@@ -16,14 +17,14 @@ class JsonReader
1617
public:
1718
JsonReader(bool verbose = true);
1819
virtual ~JsonReader();
19-
EnjoLib::Array<Computer> ReadComputers(bool verbose = false) const;
20-
EnjoLib::Array<BatteryParams> ReadBatteries(bool verbose = false) const;
21-
EnjoLib::Array<Habit> ReadHabits (bool verbose = false) const;
20+
std::vector<Computer> ReadComputers(bool verbose = false) const;
21+
std::vector<BatteryParams> ReadBatteries(bool verbose = false) const;
22+
std::vector<Habit> ReadHabits (bool verbose = false) const;
2223
System ReadSystem(bool verbose = false) const;
2324
ConfigSol ReadConfigSol(bool verbose = false) const;
2425

2526
static EnjoLib::Str GetJson(const EnjoLib::Str & fileName, bool verbose);
26-
27+
2728
protected:
2829

2930
private:

src/opti-lib/src/OptiEnProfitDataModel.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ class OptiEnProfitDataModel
3636
const ConfigSol & GetConf() const { return m_confSol; }
3737
//const EnjoLib::Array<Computer> & GetComputers() const { return m_comps; }
3838
const std::vector<Computer> & GetComputers() const { return m_comps; }
39-
const EnjoLib::Array<Habit> & GetHabits() const { return m_habits; }
39+
const std::vector<Habit> & GetHabits() const { return m_habits; }
4040
double GetHabitsUsage(int i) const;
4141
const BatteryParams & GetBatPars() const { return m_batPars; }
4242
const System & GetSystem() const { return m_sys; }
@@ -60,7 +60,7 @@ class OptiEnProfitDataModel
6060
mutable std::vector<double> m_habitsCache;
6161
//EnjoLib::Array<Computer> m_comps;
6262
std::vector<Computer> m_comps; // Choosing std::vector for runtime speed reasons.
63-
EnjoLib::Array<Habit> m_habits;
63+
std::vector<Habit> m_habits;
6464

6565
System m_sys;
6666
BatteryParams m_batPars;

src/opti-lib/src/OptimizerEnProfit.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ void OptimizerEnProfit::RandomSearch()
9292
{
9393
const ConfigSol & conf = m_dataModel.GetConf();
9494
const int horizonHours = m_dataModel.GetHorizonHours();
95-
const EnjoLib::Array<Computer> & comps = m_dataModel.GetComputers();
95+
const std::vector<Computer> & comps = m_dataModel.GetComputers();
9696
const int numComputers = comps.size();
9797

9898
const GMat gmat;

0 commit comments

Comments
 (0)