Merge pull request #245 from hf-kklein/subdivisions

Author: mj0nez

pyproject.toml

@@ -50,7 +50,7 @@ classifiers = [
     "Programming Language :: Python :: 3.13",
 ]
 dependencies = [
-    "holidays>=0.59;python_version>='3.9'",
+    "holidays>=0.78;python_version>='3.9'",
     "pytz>=2022.7.1",
     "python-dateutil",
 ]

requirements.txt

@@ -4,7 +4,7 @@
 #
 #    pip-compile pyproject.toml
 #
-holidays==0.77 ; python_version >= "3.9"
+holidays==0.78 ; python_version >= "3.9"
     # via bdew_datetimes (pyproject.toml)
 python-dateutil==2.9.0.post0
     # via

src/bdew_datetimes/calendar.py

@@ -35,6 +35,29 @@ def _populate(self, year: int) -> None:
             )
 
 
+_relevant_subdivisions: list[str] = [
+    "BB",  # Brandenburg.
+    "BE",  # Berlin.
+    "BW",  # Baden-Württemberg.
+    "BY",  # Bayern.
+    "HB",  # Bremen.
+    "HE",  # Hessen.
+    "HH",  # Hamburg.
+    "MV",  # Mecklenburg-Vorpommern.
+    "NI",  # Niedersachsen.
+    "NW",  # Nordrhein-Westfalen.
+    "RP",  # Rheinland-Pfalz.
+    "SH",  # Schleswig-Holstein.
+    "SL",  # Saarland.
+    "SN",  # Sachsen.
+    "ST",  # Sachsen-Anhalt.
+    "TH",  # Thüringen.
+    # This list contains an explicit list of all BDEW calendar relevant Germany subdivisions.
+    # It does _not_ include the 'Augsburg' subdivision which has been added in holidays v0.78.
+    # https://github.com/vacanza/holidays/commit/feab68b4377369ad52eeee9e98fc8316ec0c6f86
+]
+
+
 def create_bdew_calendar() -> HolidaySum:
     """Creates a calendar containing all days considered by the BDEW.
 
@@ -64,7 +87,7 @@ def create_bdew_calendar() -> HolidaySum:
     # If a day is holiday in any subdivision, the holiday is valid nationwide.
     # Therefore, we add all subdivisions of Germany to the BDEW specific holidays.
     # Currently, in Germany holidays are not observed.
-    for subdivision in Germany.subdivisions:
+    for subdivision in _relevant_subdivisions:
         # the method __add__ expects a Union[int, "HolidayBase", "HolidaySum"] as `other`
         # here, we're dealing with a child instance of HolidayBase
         result += Germany(

tests/test_calendar.py

@@ -31,6 +31,11 @@ def test_bdew_holidays(expected_holiday: date) -> None:
         pytest.param(date(2024, 11, 20), True, id="Buß- und Bettag (SN)"),
         pytest.param(date(2024, 12, 31), True, id="Silvester 2024 (BDEW)"),
         pytest.param(date(2025, 6, 6), True, id="Sonderfeiertag 2025 (BDEW)"),
+        pytest.param(
+            date(2025, 8, 8),
+            False,
+            id="Augsburger Friedensfest is not BDEW relevant",
+        ),
     ],
 )
 def test_create_bdew_calendar(