Fix service-derived bitrate analysis

Author: mjc

lib/reencodarr/analyzer/broadway.ex

@@ -253,11 +253,18 @@ defmodule Reencodarr.Analyzer.Broadway do
 
   # Helper function to check if MediaInfo is valid and complete
   defp has_valid_mediainfo?(video) do
-    # Check for required fields that indicate complete MediaInfo
-    is_number(video.duration) && video.duration > 0 &&
+    # Service APIs provide partial mediaInfo that can look complete enough to
+    # pass field checks while still missing the container-level bitrate. Only
+    # skip the MediaInfo command when the stored payload came from MediaInfo.
+    real_mediainfo_payload?(video.mediainfo) &&
+      is_number(video.duration) && video.duration > 0 &&
       is_number(video.bitrate) && video.bitrate > 0
   end
 
+  defp real_mediainfo_payload?(%{"creatingLibrary" => _}), do: true
+  defp real_mediainfo_payload?(%{"media" => %{"@ref" => ref}}) when is_binary(ref), do: true
+  defp real_mediainfo_payload?(_), do: false
+
   # Process videos that have MediaInfo but unchanged file size by transitioning to analyzed
   defp process_unchanged_mediainfo_videos([]), do: :ok
 

lib/reencodarr/media/video/media_info_converter.ex

@@ -171,11 +171,23 @@ defmodule Reencodarr.Media.Video.MediaInfoConverter do
   end
 
   defp calculate_overall_bitrate(file, media_info) do
-    case {file["overallBitrate"], media_info["videoBitrate"], media_info["audioBitrate"]} do
-      {overall, _, _} when is_integer(overall) and overall > 0 -> overall
-      {_, video, audio} when is_integer(video) and is_integer(audio) -> video + audio
-      {_, video, _} when is_integer(video) -> video
-      _ -> 0
+    overall = file["overallBitrate"] || media_info["overallBitrate"]
+    calculate_overall_bitrate(overall, media_info["videoBitrate"], media_info["audioBitrate"])
+  end
+
+  defp calculate_overall_bitrate(overall, video_bitrate, audio_bitrate) do
+    case {overall, video_bitrate, audio_bitrate} do
+      {overall, _, _} when is_integer(overall) and overall > 0 ->
+        overall
+
+      {_, video, audio} when is_integer(video) and video > 0 and is_integer(audio) ->
+        video + audio
+
+      {_, video, _} when is_integer(video) and video > 0 ->
+        video
+
+      _ ->
+        0
     end
   end
 
@@ -196,7 +208,8 @@ defmodule Reencodarr.Media.Video.MediaInfoConverter do
   end
 
   defp build_general_track(file, overall_bitrate, subtitles, audio_languages) do
-    duration = normalize_duration(file["runTime"])
+    media_info = file["mediaInfo"] || %{}
+    duration = normalize_duration(file["runTime"] || media_info["runTime"])
     final_bitrate = normalize_bitrate(overall_bitrate)
 
     %{
@@ -217,10 +230,9 @@ defmodule Reencodarr.Media.Video.MediaInfoConverter do
       nil -> 3600.0
       # Default to 1 hour if zero
       0 -> 3600.0
-      # Convert seconds to milliseconds
-      time when is_integer(time) -> time * 1000.0
-      # Convert seconds to milliseconds
-      time when is_float(time) -> time * 1000.0
+      time when is_integer(time) -> time * 1.0
+      time when is_float(time) -> time
+      time when is_binary(time) -> Parsers.parse_duration(time)
       _ -> 3600.0
     end
   end

test/reencodarr/media/video/media_info_converter_test.exs

@@ -176,6 +176,55 @@ defmodule Reencodarr.Media.Video.MediaInfoConverterTest do
       assert general["OverallBitRate"] == 5000
     end
 
+    test "does not use audio bitrate as overall bitrate when video bitrate is missing" do
+      file =
+        minimal_service_file(%{
+          "runTime" => nil,
+          "overallBitrate" => nil,
+          "mediaInfo" => %{
+            "width" => 1920,
+            "height" => 1080,
+            "videoCodec" => "x264",
+            "audioCodec" => "DTS",
+            "audioChannels" => 5.1,
+            "audioLanguages" => "eng",
+            "subtitles" => "",
+            "videoBitrate" => 0,
+            "audioBitrate" => 1_536_000,
+            "runTime" => "42:39"
+          }
+        })
+
+      %{"media" => %{"track" => tracks}} = MediaInfoConverter.from_service_file(file, :sonarr)
+      general = Enum.find(tracks, &(&1["@type"] == "General"))
+
+      assert general["OverallBitRate"] == 0
+      assert general["Duration"] == 2559
+    end
+
+    test "sums video and audio bitrate only when video bitrate is positive" do
+      file =
+        minimal_service_file(%{
+          "overallBitrate" => nil,
+          "mediaInfo" => %{
+            "width" => 1920,
+            "height" => 1080,
+            "videoCodec" => "HEVC",
+            "audioCodec" => "AAC",
+            "audioChannels" => 2,
+            "audioLanguages" => "eng",
+            "subtitles" => "",
+            "videoBitrate" => 4_000_000,
+            "audioBitrate" => 192_000
+          }
+        })
+
+      %{"media" => %{"track" => tracks}} = MediaInfoConverter.from_service_file(file, :sonarr)
+      general = Enum.find(tracks, &(&1["@type"] == "General"))
+
+      assert general["OverallBitRate"] == 4_192_000
+    end
+
     test "handles missing mediaInfo gracefully" do
       file = Map.delete(minimal_service_file(), "mediaInfo")
       result = MediaInfoConverter.from_service_file(file, :sonarr)