Bulk pricing table follows the admin-bar switcher role

The [pricebook_bulk_table] / [pricebook_bulk_pricing_applies] shortcodes (via
bulk_sections) resolved the current view's tier with user_pricing_role(), which
only reads the user's own roles. A manager previewing a specific ROLE through
the admin-bar switcher was ignored, so the table stayed hidden even when the
previewed role had quantity breaks.

bulk_sections now takes the manager's switcher role first (mirroring
active_tier_label() and the engine's switcher precedence), then falls back to
the pricing user's own tier (which already honors a switcher-impersonated user
via pricing_user_id). Net: the table shows exactly when the currently-previewed
pricing — the current user's tier, or the switcher's role/user — has bulk breaks.

Adds a shortcode_atts test shim and ShortcodesTest covering the three cases.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: mjoslyn

src/Shortcodes.php

@@ -221,10 +221,20 @@ private function bulk_sections( $product_id, $role ) {
 		} elseif ( '' !== $role ) {
 			$role_keys = isset( $tiers[ $role ] ) ? array( $role ) : array();
 		} else {
-			if ( $this->engine->user_has_override( $product_id ) ) {
-				return array();
+			// Reflect the admin-bar switcher so the table shows exactly when the
+			// currently-previewed pricing has quantity breaks: a manager previewing a
+			// specific ROLE uses that role; a manager previewing a USER (or a normal
+			// customer) uses that user's own tier via pricing_user_id(). Mirrors
+			// active_tier_label() and the engine's switcher precedence.
+			$active = $this->context->is_manager() ? $this->context->switcher_role() : '';
+			if ( '' === $active ) {
+				// Pricing as an actual user: a per-user negotiated override suppresses
+				// bulk (the negotiated price wins). Not relevant to a previewed role.
+				if ( $this->engine->user_has_override( $product_id ) ) {
+					return array();
+				}
+				$active = $this->context->user_pricing_role( $this->context->pricing_user_id() );
 			}
-			$active    = $this->context->user_pricing_role( $this->context->pricing_user_id() );
 			$role_keys = ( '' !== $active && isset( $tiers[ $active ] ) ) ? array( $active ) : array();
 		}
 

tests/ShortcodesTest.php

@@ -0,0 +1,70 @@
+<?php
+/**
+ * Shortcodes tests: bulk-pricing visibility follows the effective pricing view.
+ *
+ * @package WCPricebook\Tests
+ */
+
+declare( strict_types=1 );
+
+namespace WCPricebook\Tests;
+
+/**
+ * @covers \WCPricebook\Shortcodes
+ */
+class ShortcodesTest extends TestCase {
+
+	/**
+	 * @return \WCPricebook\Shortcodes
+	 */
+	private function shortcodes() {
+		return new \WCPricebook\Shortcodes( $this->config, $this->context, $this->engine );
+	}
+
+	/**
+	 * @return void
+	 */
+	private function seed_dealer_bulk_product() {
+		$this->set_meta(
+			10,
+			array(
+				'_regular_price'          => '100',
+				'dealer_price'            => '70',
+				'_pricebook_bulk_pricing' => array( 'dealer' => array( array( 'min_qty' => 10, 'price' => '65' ) ) ),
+			)
+		);
+	}
+
+	public function test_bulk_applies_for_current_user_with_bulk_tier() {
+		$this->seed_dealer_bulk_product();
+		Store::add_user( 5, array( 'dealer' ), array( 'dealer' ) );
+		Store::$current_user = 5;
+
+		$this->assertSame( '1', $this->shortcodes()->render_bulk_applies( array( 'product' => 10 ) ) );
+	}
+
+	public function test_bulk_hidden_for_user_without_bulk_tier() {
+		$this->seed_dealer_bulk_product();
+		Store::add_user( 6, array( 'customer' ), array() );
+		Store::$current_user = 6;
+
+		$this->assertSame( '', $this->shortcodes()->render_bulk_applies( array( 'product' => 10 ) ) );
+	}
+
+	public function test_bulk_follows_manager_switcher_role() {
+		// A manager who is NOT a dealer, previewing as 'dealer' via the admin-bar
+		// switcher, must see the bulk table — the shortcode reflects the switcher
+		// role, not the manager's own roles.
+		$this->seed_dealer_bulk_product();
+		Store::add_user( 9, array( 'shop_manager' ), array( 'manage_woocommerce' ) );
+		Store::$current_user = 9;
+		$sc = $this->shortcodes();
+
+		// No switcher: the manager holds no bulk tier of their own -> hidden.
+		$this->assertSame( '', $sc->render_bulk_applies( array( 'product' => 10 ) ) );
+
+		// Switcher set to 'dealer' (a role with a bulk break) -> shown.
+		Store::$user_meta[9]['pricebook_switcher_role'] = 'dealer';
+		$this->assertSame( '1', $sc->render_bulk_applies( array( 'product' => 10 ) ) );
+	}
+}

tests/wp-shims.php

@@ -314,3 +314,23 @@ function current_user_can( $capability, ...$args ) {
 		return ! empty( Store::$user_caps[ $id ][ $capability ] );
 	}
 }
+
+if ( ! function_exists( 'shortcode_atts' ) ) {
+	/**
+	 * Merge user shortcode attributes over defaults (the WordPress semantics: only
+	 * keys present in $defaults survive).
+	 *
+	 * @param array<string,mixed> $defaults  Default attributes.
+	 * @param mixed               $atts      Supplied attributes.
+	 * @param string              $shortcode Shortcode tag (unused here).
+	 * @return array<string,mixed>
+	 */
+	function shortcode_atts( $defaults, $atts, $shortcode = '' ) {
+		$atts = (array) $atts;
+		$out  = array();
+		foreach ( (array) $defaults as $name => $default ) {
+			$out[ $name ] = array_key_exists( $name, $atts ) ? $atts[ $name ] : $default;
+		}
+		return $out;
+	}
+}