Skip to content

Commit 7ce6533

Browse files
committed
response root element removed from response data array to handle clean response
1 parent 6953f7f commit 7ce6533

11 files changed

+22
-7
lines changed

src/SDK/Client.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ private function request(EndpointInterface $endpoint) : array
134134
'status' => $responseBody['status'],
135135
'code' => $responseBody['message']['code']
136136
],
137-
'data' => $responseBody['data']
137+
'data' => $responseBody['data'][$endpoint->getResponseRoot()]
138138
];
139139
}
140140

src/SDK/Endpoint/CalculateAwardMilesWithTax.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ final class CalculateAwardMilesWithTax extends EndpointAbstract implements Endpo
1010
public function __construct(CalculateAwardMilesWithTaxParameters $queryParameters)
1111
{
1212
$this->endpoint = '/calculateAwardMilesWithTax';
13+
$this->responseRoot = 'return';
1314
$this->queryParameters = $queryParameters->getValue();
1415
}
1516
}

src/SDK/Endpoint/CalculateFlightMiles.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ final class CalculateFlightMiles extends EndpointAbstract implements EndpointInt
1010
public function __construct(CalculateFlightMilesParameters $queryParameters)
1111
{
1212
$this->endpoint = '/calculateFlightMiles';
13+
$this->responseRoot = 'milesResponseDetail';
1314
$this->queryParameters = $queryParameters->getValue();
1415
}
1516
}

src/SDK/Endpoint/EndpointAbstract.php

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ abstract class EndpointAbstract
88
protected $queryParameters = [];
99
protected $headers = [];
1010
protected $httpRequestMethod = 'POST';
11+
protected $responseRoot = '';
1112

1213
public function getEndpoint() : string
1314
{
@@ -28,4 +29,9 @@ public function getHttpRequestMethod() : string
2829
{
2930
return $this->httpRequestMethod;
3031
}
32+
33+
public function getResponseRoot() : string
34+
{
35+
return $this->responseRoot;
36+
}
3137
}

src/SDK/Endpoint/EndpointInterface.php

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,9 @@
55

66
interface EndpointInterface
77
{
8-
public function getEndpoint();
9-
public function getHeaders();
10-
public function getQueryParams();
11-
public function getHttpRequestMethod();
8+
public function getEndpoint() : string;
9+
public function getHeaders() : array;
10+
public function getQueryParams() : array;
11+
public function getHttpRequestMethod() : string;
12+
public function getResponseRoot() : string;
1213
}

src/SDK/Endpoint/GetAvailability.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ final class GetAvailability extends EndpointAbstract implements EndpointInterfac
1010
public function __construct(GetAvailabilityParameters $queryParameters)
1111
{
1212
$this->endpoint = '/getAvailability';
13+
$this->responseRoot = 'availabilityOTAResponse';
1314
$this->queryParameters = $queryParameters->getValue();
1415
}
1516
}

src/SDK/Endpoint/GetFareFamilyList.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ final class GetFareFamilyList extends EndpointAbstract implements EndpointInterf
1010
public function __construct(GetFareFamilyListParameters $queryParameters)
1111
{
1212
$this->endpoint = '/getFareFamilyList';
13+
$this->responseRoot = 'fareFamilyOTAResponse';
1314
$this->queryParameters = $queryParameters->getValue();
1415
}
1516
}

src/SDK/Endpoint/GetPortList.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ public function __construct(GetPortListParameters $queryParameters)
1111
{
1212
$this->endpoint = '/getPortList';
1313
$this->httpRequestMethod = 'GET';
14+
$this->responseRoot = 'Port';
1415
$this->queryParameters = $queryParameters->getValue();
1516
}
1617
}

src/SDK/Endpoint/GetTimetable.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,11 @@
77

88
final class GetTimetable extends EndpointAbstract implements EndpointInterface
99
{
10+
1011
public function __construct(GetTimetableParameters $queryParameters)
1112
{
1213
$this->endpoint = '/getTimeTable';
14+
$this->responseRoot = 'timeTableOTAResponse';
1315
$this->queryParameters = $queryParameters->getValue();
1416
}
1517
}

src/SDK/Endpoint/RetrieveReservationDetail.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ final class RetrieveReservationDetail extends EndpointAbstract implements Endpoi
1010
public function __construct(RetrieveReservationDetailParameters $queryParameters)
1111
{
1212
$this->endpoint = '/retrieveReservationDetail';
13+
$this->responseRoot = 'retrieveReservationOTAResponse';
1314
$this->httpRequestMethod = 'get';
1415
$this->queryParameters = $queryParameters->getValue();
1516
}

0 commit comments

Comments
 (0)