Chore: Tests refactoring timeouts (ajaxorg#5929)

* add `sleep` utility function and replace `setTimeout` in async test cases

* replace `setTimeout` with `lang.sleep` and update tests to use async/await

* replace `setTimeout` with `lang.sleep` in tests and refactor to use async/await

* resolve merge conflicts

* refactor tests to use async/await and remove redundant `Promise` wrappers

* undo formatting changes

* fix regression in autocomplete_test.js

* cleanup

---------

Co-authored-by: nightwing <amirjanyan@gmail.com>

Author: mkslanc

src/ace_test.js

@@ -7,6 +7,7 @@ if (typeof process !== "undefined") {
 var dom = require("./lib/dom");
 var ace = require("./ace");
 var assert = require("./test/assertions");
+var lang = require("./lib/lang");
 
 module.exports = {
    "test: ace edit" : function() {
@@ -50,7 +51,7 @@ module.exports = {
         assert.equal("h", editor.getValue());
         document.body.removeChild(el);
     },
-    "test: destroy": function(done) {
+    "test: destroy": async function(done) {
         var editor = ace.edit();
         var mouseTarget = editor.renderer.getMouseEventTarget();
         var textarea = editor.textInput.getElement();
@@ -76,15 +77,14 @@ module.exports = {
         click(mouseTarget);
         assert.equal(focusCalled, 1);
 
-        setTimeout(function() {
-            assert.notOk(!!editor.curOp);
-            
-            // input commands on destroed editor without session do not throw errors
-            editor.setSession(null);
-            sendText(textarea, "2");
-            
-            done();
-        });
+        await lang.sleep(0);
+        assert.notOk(!!editor.curOp);
+
+        // input commands on destroed editor without session do not throw errors
+        editor.setSession(null);
+        sendText(textarea, "2");
+
+        done();
     },
     "test: useStrictCSP": function() {
         ace.config.set("useStrictCSP", undefined);
@@ -101,7 +101,7 @@ module.exports = {
         ace.config.set("useStrictCSP", false);
         assert.ok(getStyleNode());
     },
-    "test: resizeObserver": function(done) {
+    "test: resizeObserver": async function(done) {
         var mockObserver = {
             disconnect: function() { mockObserver.target = null; },
             observe: function(el) {
@@ -131,31 +131,31 @@ module.exports = {
         assert.equal(editor.renderer.$size.width, 100);
         editor.container.style.width = "200px";
         mockObserver.call();
-        setTimeout(function() {
-            if (editor.renderer.$resizeTimer.isPending())
-                editor.renderer.$resizeTimer.call();
-            assert.equal(editor.renderer.$size.width, 200);
-            editor.container.style.height = "200px";
-            mockObserver.call();
-            setTimeout(function() {
-                assert.ok(editor.renderer.$resizeTimer.isPending());
-                editor.container.style.height = "100px";
-                mockObserver.call();
-                setTimeout(function() {
-                    assert.ok(!editor.renderer.$resizeTimer.isPending());
-                    editor.setOption("useResizeObserver", false);
-                    editor.container.style.height = "300px";
-                    mockObserver.call();
-                    assert.ok(!editor.renderer.$resizeObserver);
-                    editor.setOption("useResizeObserver", true);
-                    assert.ok(editor.renderer.$resizeObserver);
-                    if (window.ResizeObserver === mockObserver.$create)
-                        window.ResizeObserver = undefined;
-                    editor.destroy();
-                    done();
-                }, 15);
-            }, 15);
-        }, 15);
+
+        await lang.sleep(15);
+        if (editor.renderer.$resizeTimer.isPending())
+            editor.renderer.$resizeTimer.call();
+        assert.equal(editor.renderer.$size.width, 200);
+        editor.container.style.height = "200px";
+        mockObserver.call();
+
+        await lang.sleep(15);
+        assert.ok(editor.renderer.$resizeTimer.isPending());
+        editor.container.style.height = "100px";
+        mockObserver.call();
+
+        await lang.sleep(15);
+        assert.ok(!editor.renderer.$resizeTimer.isPending());
+        editor.setOption("useResizeObserver", false);
+        editor.container.style.height = "300px";
+        mockObserver.call();
+        assert.ok(!editor.renderer.$resizeObserver);
+        editor.setOption("useResizeObserver", true);
+        assert.ok(editor.renderer.$resizeObserver);
+        if (window.ResizeObserver === mockObserver.$create)
+            window.ResizeObserver = undefined;
+        editor.destroy();
+        done();
     },
     "test: edit template" : function() {
         var template = document.createElement("template");

src/autocomplete/inline_test.js

@@ -10,6 +10,7 @@ var AceInline = require("./inline").AceInline;
 var Editor = require("../ace").Editor;
 var EditSession = require("../ace").EditSession;
 var VirtualRenderer = require("../ace").VirtualRenderer;
+var lang = require("../lib/lang");
 
 var editor;
 var editor2;
@@ -272,7 +273,7 @@ module.exports = {
 
         done();
     },
-    "test: should scroll if inline preview outside": function(done) {
+    "test: should scroll if inline preview outside": async function(done) {
         // Fill the editor with new lines to get the cursor to the bottom
         // of the container
         editor.execCommand("insertstring", "\n".repeat(200));
@@ -289,25 +290,23 @@ module.exports = {
 
         inline.show(editor, completions[6], "l");
         editor.renderer.$loop._flush();
-        
-        setTimeout(() => {
-            // Should scroll 5 lines to get the inline preview into view
-            assert.strictEqual(deltaY, 50);
 
-            inline.hide();
-            editor.renderer.$loop._flush();
+        await lang.sleep(50);
+        // Should scroll 5 lines to get the inline preview into view
+        assert.strictEqual(deltaY, 50);
 
-            inline.show(editor, completions[7], "l");
-            editor.renderer.$loop._flush();
+        inline.hide();
+        editor.renderer.$loop._flush();
+
+        inline.show(editor, completions[7], "l");
+        editor.renderer.$loop._flush();
 
-            setTimeout(() => {
-                // Should scroll as much as possbile while keeping the cursor on screen
-                assert.strictEqual(row, 202);
-                editor.renderer.scrollBy = initialScrollBy;
-                editor.renderer.scrollToRow = initialScrollToRow;
-                done();
-            }, 50); 
-        }, 50);  
+        await lang.sleep(50);
+        // Should scroll as much as possbile while keeping the cursor on screen
+        assert.strictEqual(row, 202);
+        editor.renderer.scrollBy = initialScrollBy;
+        editor.renderer.scrollToRow = initialScrollToRow;
+        done();
     },
     "test: renders multi-line ghost text with empty lines": function(done) {
         assert.equal(editor.renderer.$ghostTextWidget, null);